Skip to content
Permalink
Browse files
8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/…
…CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled

Reviewed-by: rhalade
  • Loading branch information
thejasviv authored and Abdul Kolarkunnu committed Aug 20, 2021
1 parent ddcd851 commit 4bd37c315333325b69db8d55c0c3aaf74c95024f
Showing 1 changed file with 2 additions and 6 deletions.
@@ -57,18 +57,15 @@ public static void main(String[] args) throws Exception {

ValidatePathWithParams pathValidator = new ValidatePathWithParams(null);

boolean ocspEnabled = true;

if (args.length >= 1 && "CRL".equalsIgnoreCase(args[0])) {
pathValidator.enableCRLCheck();
ocspEnabled = false;
} else {
// OCSP check by default
pathValidator.enableOCSPCheck();
}

new BuypassClass2().runTest(pathValidator);
new BuypassClass3().runTest(pathValidator, ocspEnabled);
new BuypassClass3().runTest(pathValidator);
}
}

@@ -320,8 +317,7 @@ class BuypassClass3 {
"BJmiWd5uUxev0nVw0saqvlo4yAEBq4rI/DieKcQI4qEI8myzoS0R0azMfLM=\n" +
"-----END CERTIFICATE-----";

public void runTest(ValidatePathWithParams pathValidator, boolean ocspEnabled)
throws Exception {
public void runTest(ValidatePathWithParams pathValidator) throws Exception {
// Validate valid
pathValidator.validate(new String[]{VALID_CLASS_3, INT_CLASS_3},
ValidatePathWithParams.Status.GOOD, null, System.out);

3 comments on commit 4bd37c3

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on 4bd37c3 Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented on 4bd37c3 Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 4bd37c3 Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealMDoerr @TheRealMDoerr the backport was successfully created on the branch TheRealMDoerr-backport-4bd37c31 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

this pull request contains a backport of commit 4bd37c31 from the openjdk/jdk repository.

The commit being backported was authored by Thejasvi Voniadka on 20 Aug 2021 and was reviewed by Rajan Halade.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev TheRealMDoerr-backport-4bd37c31:TheRealMDoerr-backport-4bd37c31
$ git checkout TheRealMDoerr-backport-4bd37c31
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev TheRealMDoerr-backport-4bd37c31

Please sign in to comment.