Skip to content

Commit 4d4951a

Browse files
committed
8343889: Test runtime/cds/appcds/redefineClass/RedefineBasicTest.java failed
8344046: Tests under cds/appcds/jvmti/redefineClasses should have @requires vm.cds Reviewed-by: iklam, matsaave
1 parent 697f27c commit 4d4951a

File tree

6 files changed

+9
-10
lines changed

6 files changed

+9
-10
lines changed

test/hotspot/jtreg/runtime/cds/appcds/jvmti/redefineClasses/OldClassAndRedefineClass.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@
2626
* @test
2727
* @bug 8342303
2828
* @summary Test loading of shared old class when another class has been redefined.
29-
* @library /test/lib /test/hotspot/jtreg/runtime/cds/appcds /test/hotspot/jtreg/runtime/cds/appcds/test-classes /test/hotspot/jtreg/runtime/cds/appcds/jvmti
30-
* @requires vm.cds.write.archived.java.heap
29+
* @library /test/lib /test/hotspot/jtreg/runtime/cds/appcds /test/hotspot/jtreg/runtime/cds/appcds/test-classes
30+
* @requires vm.cds
3131
* @requires vm.jvmti
32+
* @run driver RedefineClassHelper
3233
* @build jdk.test.whitebox.WhiteBox
3334
* OldClassAndRedefineClassApp
3435
* @compile ../../test-classes/OldSuper.jasm
3536
* ../../test-classes/ChildOldSuper.java
3637
* ../../test-classes/Hello.java
37-
* @run driver RedefineClassHelper
3838
* @run driver OldClassAndRedefineClass
3939
*/
4040

test/hotspot/jtreg/runtime/cds/appcds/jvmti/redefineClasses/RedefineBootClassTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@
2929
* @library /test/lib
3030
* /test/hotspot/jtreg/runtime/cds/appcds
3131
* /test/hotspot/jtreg/runtime/cds/appcds/test-classes
32-
* /test/hotspot/jtreg/runtime/cds/appcds/jvmti
32+
* @requires vm.cds
3333
* @requires vm.jvmti
34+
* @run driver RedefineClassHelper
3435
* @build RedefineBootClassTest
3536
* RedefineBootClassApp
3637
* BootSuper BootChild
37-
* @run driver RedefineClassHelper
3838
* @run driver RedefineBootClassTest
3939
*/
4040

test/hotspot/jtreg/runtime/cds/appcds/jvmti/redefineClasses/RedefineOldSuperTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@
2929
* @library /test/lib
3030
* /test/hotspot/jtreg/runtime/cds/appcds
3131
* /test/hotspot/jtreg/runtime/cds/appcds/test-classes
32-
* /test/hotspot/jtreg/runtime/cds/appcds/jvmti
32+
* @requires vm.cds
3333
* @requires vm.jvmti
3434
* @compile ../../test-classes/OldSuper.jasm
35+
* @run driver RedefineClassHelper
3536
* @build RedefineOldSuperTest
3637
* RedefineOldSuperApp
3738
* NewChild
38-
* @run driver RedefineClassHelper
3939
* @run driver RedefineOldSuperTest
4040
*/
4141

test/hotspot/jtreg/runtime/cds/appcds/redefineClass/RedefineBasicTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* @requires vm.jvmti
3131
* @library /test/lib /test/hotspot/jtreg/serviceability/jvmti/RedefineClasses /test/hotspot/jtreg/runtime/cds/appcds
3232
* @run driver RedefineClassHelper
33-
* @build jdk.test.whitebox.WhiteBox jdk.test.lib.compiler.InMemoryJavaCompiler RedefineBasic
33+
* @build jdk.test.whitebox.WhiteBox RedefineBasic
3434
* @run driver RedefineBasicTest
3535
*/
3636

test/hotspot/jtreg/runtime/cds/appcds/redefineClass/RedefineRunningMethods_Shared.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* @requires vm.jvmti
3131
* @library /test/lib /test/hotspot/jtreg/serviceability/jvmti/RedefineClasses /test/hotspot/jtreg/runtime/cds/appcds
3232
* @run driver RedefineClassHelper
33-
* @build jdk.test.whitebox.WhiteBox jdk.test.lib.compiler.InMemoryJavaCompiler
33+
* @build jdk.test.whitebox.WhiteBox
3434
* @compile RedefineRunningMethods_SharedHelper.java
3535
* @run driver RedefineRunningMethods_Shared
3636
*/

test/hotspot/jtreg/runtime/logging/RedefineClasses.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
* @modules java.compiler
3131
* java.instrument
3232
* @requires vm.jvmti
33-
* @build jdk.test.lib.compiler.InMemoryJavaCompiler
3433
* @run main RedefineClassHelper
3534
* @run main/othervm -Xmx256m -XX:MaxMetaspaceSize=64m -javaagent:redefineagent.jar -Xlog:all=trace:file=all.log RedefineClasses
3635
*/

0 commit comments

Comments
 (0)