8319704: LogTagSet::set_output_level() should not accept NULL as LogOutput

tstuefe · tstuefe · commit 4d650fe85fe7 · 2023-11-13T08:31:06.000Z
Reviewed-by: jsjolen, dholmes
diff --git a/src/hotspot/share/logging/logOutputList.cpp b/src/hotspot/share/logging/logOutputList.cpp
@@ -52,6 +52,7 @@ void LogOutputList::wait_until_no_readers() const {
 }
 
 void LogOutputList::set_output_level(LogOutput* output, LogLevelType level) {
+  assert(output != nullptr, "LogOutput is null");
   LogOutputNode* node = find(output);
   if (level == LogLevel::Off && node != nullptr) {
     remove_output(node);

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ void LogOutputList::wait_until_no_readers() const {`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`void LogOutputList::set_output_level(LogOutput* output, LogLevelType level) {`
	`55`	`+ assert(output != nullptr, "LogOutput is null");`
`55`	`56`	`LogOutputNode* node = find(output);`
`56`	`57`	`if (level == LogLevel::Off && node != nullptr) {`
`57`	`58`	`remove_output(node);`