Skip to content

Commit

Permalink
8282172: CompileBroker::log_metaspace_failure is called from non-Java…
Browse files Browse the repository at this point in the history 
…/compiler threads

Reviewed-by: kvn, thartmann
  • Loading branch information
@shipilev
shipilev committed Feb 28, 2022
1 parent 0ae3d1d commit 4e7fb41
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/hotspot/share/compiler/compileBroker.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -225,11 +225,13 @@ class CompilationLog : public StringEventLog {
}

void log_metaspace_failure(const char* reason) {
// Note: This method can be called from non-Java/compiler threads to
// log the global metaspace failure that might affect profiling.
ResourceMark rm;
StringLogMessage lm;
lm.print("%4d COMPILE PROFILING SKIPPED: %s", -1, reason);
lm.print("\n");
log(JavaThread::current(), "%s", (const char*)lm);
log(Thread::current(), "%s", (const char*)lm);
}
};

Expand Down

5 comments on commit 4e7fb41

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@TheRealMDoerr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 4e7fb41 Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealMDoerr the backport was successfully created on the branch TheRealMDoerr-backport-4e7fb41d in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 4e7fb41d from the openjdk/jdk repository.

The commit being backported was authored by Aleksey Shipilev on 28 Feb 2022 and was reviewed by Vladimir Kozlov and Tobias Hartmann.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev TheRealMDoerr-backport-4e7fb41d:TheRealMDoerr-backport-4e7fb41d
$ git checkout TheRealMDoerr-backport-4e7fb41d
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev TheRealMDoerr-backport-4e7fb41d

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 4e7fb41 Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 4e7fb41 Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-4e7fb41d in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 4e7fb41d from the openjdk/jdk repository.

The commit being backported was authored by Aleksey Shipilev on 28 Feb 2022 and was reviewed by Vladimir Kozlov and Tobias Hartmann.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-4e7fb41d:GoeLin-backport-4e7fb41d
$ git checkout GoeLin-backport-4e7fb41d
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-4e7fb41d

Please sign in to comment.