Skip to content

Commit

Permalink
8307653: Adjust delay time and gc log argument in TestAbortOnVMOperat…
Browse files Browse the repository at this point in the history
…ionTimeout

Reviewed-by: dholmes, dcubed
  • Loading branch information
lgxbslgx committed May 11, 2023
1 parent 1535863 commit 4f355c3
Showing 1 changed file with 5 additions and 7 deletions.
Expand Up @@ -26,7 +26,7 @@

/*
* @test TestAbortOnVMOperationTimeout
* @bug 8181143 8269523
* @bug 8181143 8269523 8307653
* @summary Check abort on VM timeout is working
* @requires vm.flagless
* @library /test/lib
Expand All @@ -51,11 +51,9 @@ public static void main(String[] args) throws Exception {
return;
}

// These should definitely pass: more than a minute is enough for Serial to act.
// The values are deliberately non-round to trip off periodic task granularity.
for (int delay : new int[]{63423, 12388131}) {
testWith(delay, true);
}
// This should definitely pass: more than 3 minutes is enough for Serial to act.
// The value is deliberately non-round to trip off periodic task granularity.
testWith(183423, true);

// These should fail: Serial is not very fast but we have seen the test
// execute as quickly as 2ms!
Expand All @@ -72,7 +70,7 @@ public static void testWith(int delay, boolean shouldPass) throws Exception {
"-Xmx256m",
"-XX:+UseSerialGC",
"-XX:-CreateCoredumpOnCrash",
"-Xlog:gc",
"-Xlog:gc*=info",
"TestAbortOnVMOperationTimeout",
"foo"
);
Expand Down

3 comments on commit 4f355c3

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 4f355c3 Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 4f355c3 Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-4f355c35 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 4f355c35 from the openjdk/jdk repository.

The commit being backported was authored by Guoxiong Li on 11 May 2023 and was reviewed by David Holmes and Daniel D. Daugherty.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git GoeLin-backport-4f355c35:GoeLin-backport-4f355c35
$ git checkout GoeLin-backport-4f355c35
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git GoeLin-backport-4f355c35

Please sign in to comment.