From 5489c821dc2e0c3cfa207dc96d9183d165640368 Mon Sep 17 00:00:00 2001 From: Glavo Date: Tue, 21 Feb 2023 17:35:52 +0000 Subject: [PATCH] 8302603: Use Set.of in java.nio.charset.Charset Reviewed-by: stsypanov, alanb, naoto --- .../share/classes/java/nio/charset/Charset.java | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/java.base/share/classes/java/nio/charset/Charset.java b/src/java.base/share/classes/java/nio/charset/Charset.java index dbaa2a2f12daa..894965bf4d22a 100644 --- a/src/java.base/share/classes/java/nio/charset/Charset.java +++ b/src/java.base/share/classes/java/nio/charset/Charset.java @@ -38,7 +38,6 @@ import java.security.PrivilegedAction; import java.util.Arrays; import java.util.Collections; -import java.util.HashSet; import java.util.Iterator; import java.util.Locale; import java.util.Map; @@ -667,7 +666,7 @@ public static Charset defaultCharset() { private final String name; // tickles a bug in oldjavac private final String[] aliases; // tickles a bug in oldjavac - private Set aliasSet = null; + private Set aliasSet; /** * Initializes a new charset with the given canonical name and alias @@ -714,14 +713,12 @@ public final String name() { * @return An immutable set of this charset's aliases */ public final Set aliases() { - if (aliasSet != null) - return aliasSet; - int n = aliases.length; - HashSet hs = HashSet.newHashSet(n); - for (int i = 0; i < n; i++) - hs.add(aliases[i]); - aliasSet = Collections.unmodifiableSet(hs); - return aliasSet; + Set set = this.aliasSet; + if (set == null) { + set = Set.of(aliases); + this.aliasSet = set; + } + return set; } /**