11/*
2- * Copyright (c) 2019, 2020 , Oracle and/or its affiliates. All rights reserved.
2+ * Copyright (c) 2019, 2024 , Oracle and/or its affiliates. All rights reserved.
33 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44 *
55 * This code is free software; you can redistribute it and/or modify it
2222 */
2323
2424/* @test
25- * @bug 8181493 8231174
25+ * @bug 8181493 8231174 8343417
2626 * @summary Verify that nanosecond precision is maintained for file timestamps
2727 * @requires (os.family == "linux") | (os.family == "mac") | (os.family == "windows")
28+ * @library ../.. /test/lib
29+ * @build jdk.test.lib.Platform
2830 * @modules java.base/sun.nio.fs:+open
31+ * @run main SetTimesNanos
2932 */
3033
3134import java .io .IOException ;
3639import java .nio .file .attribute .BasicFileAttributes ;
3740import java .nio .file .attribute .BasicFileAttributeView ;
3841import java .nio .file .attribute .FileTime ;
42+ import java .util .List ;
3943import java .util .Set ;
40- import java .util .concurrent .TimeUnit ;
44+
45+ import static java .nio .file .LinkOption .*;
46+ import static java .util .concurrent .TimeUnit .*;
47+
48+ import jdk .test .lib .Platform ;
49+ import jtreg .SkippedException ;
4150
4251public class SetTimesNanos {
43- private static final boolean IS_WINDOWS =
44- System .getProperty ("os.name" ).startsWith ("Windows" );
4552
4653 public static void main (String [] args ) throws Exception {
47- if (!IS_WINDOWS ) {
54+ if (!Platform . isWindows () ) {
4855 // Check whether futimens() system call is supported
4956 Class unixNativeDispatcherClass =
5057 Class .forName ("sun.nio.fs.UnixNativeDispatcher" );
5158 Method futimensSupported =
5259 unixNativeDispatcherClass .getDeclaredMethod ("futimensSupported" );
5360 futimensSupported .setAccessible (true );
5461 if (!(boolean )futimensSupported .invoke (null )) {
55- System .err .println ("futimens() not supported; skipping test" );
56- return ;
62+ throw new SkippedException ("futimens() not supported" );
5763 }
5864 }
5965
@@ -63,30 +69,34 @@ public static void main(String[] args) throws Exception {
6369 System .out .format ("FileStore: \" %s\" on %s (%s)%n" ,
6470 dir , store .name (), store .type ());
6571
66- Set <String > testedTypes = IS_WINDOWS ?
72+ Set <String > testedTypes = Platform . isWindows () ?
6773 Set .of ("NTFS" ) : Set .of ("apfs" , "ext4" , "xfs" , "zfs" );
6874 if (!testedTypes .contains (store .type ())) {
69- System .err .format ("%s not in %s; skipping test" , store .type (), testedTypes );
70- return ;
75+ throw new SkippedException (store .type () + " not in " + testedTypes );
7176 }
7277
7378 testNanos (dir );
7479
7580 Path file = Files .createFile (dir .resolve ("test.dat" ));
7681 testNanos (file );
82+
83+ if (Platform .isLinux ()) {
84+ testNanosLink (false );
85+ testNanosLink (true );
86+ }
7787 }
7888
7989 private static void testNanos (Path path ) throws IOException {
8090 // Set modification and access times
8191 // Time stamp = "2017-01-01 01:01:01.123456789";
8292 long timeNanos = 1_483_261_261L *1_000_000_000L + 123_456_789L ;
83- FileTime pathTime = FileTime .from (timeNanos , TimeUnit . NANOSECONDS );
93+ FileTime pathTime = FileTime .from (timeNanos , NANOSECONDS );
8494 BasicFileAttributeView view =
8595 Files .getFileAttributeView (path , BasicFileAttributeView .class );
8696 view .setTimes (pathTime , pathTime , null );
8797
8898 // Windows file time resolution is 100ns so truncate
89- if (IS_WINDOWS ) {
99+ if (Platform . isWindows () ) {
90100 timeNanos = 100L *(timeNanos /100L );
91101 }
92102
@@ -99,12 +109,50 @@ private static void testNanos(Path path) throws IOException {
99109 FileTime [] times = new FileTime [] {attrs .lastModifiedTime (),
100110 attrs .lastAccessTime ()};
101111 for (int i = 0 ; i < timeNames .length ; i ++) {
102- long nanos = times [i ].to (TimeUnit . NANOSECONDS );
112+ long nanos = times [i ].to (NANOSECONDS );
103113 if (nanos != timeNanos ) {
104114 throw new RuntimeException ("Expected " + timeNames [i ] +
105115 " timestamp to be '" + timeNanos + "', but was '" +
106116 nanos + "'" );
107117 }
108118 }
109119 }
120+
121+ private static void testNanosLink (boolean absolute ) throws IOException {
122+ System .out .println ("absolute: " + absolute );
123+
124+ var target = Path .of ("target" );
125+ var symlink = Path .of ("symlink" );
126+ if (absolute )
127+ symlink = symlink .toAbsolutePath ();
128+
129+ try {
130+ Files .createFile (target );
131+ Files .createSymbolicLink (symlink , target );
132+
133+ var newTime = FileTime .from (1730417633157646106L , NANOSECONDS );
134+ System .out .println ("newTime: " + newTime .to (NANOSECONDS ));
135+
136+ for (Path p : List .of (target , symlink )) {
137+ System .out .println ("p: " + p );
138+
139+ var view = Files .getFileAttributeView (p ,
140+ BasicFileAttributeView .class , NOFOLLOW_LINKS );
141+ view .setTimes (newTime , newTime , null );
142+ var attrs = view .readAttributes ();
143+
144+ if (!attrs .lastAccessTime ().equals (newTime ))
145+ throw new RuntimeException ("Last access time "
146+ + attrs .lastAccessTime ()
147+ + " != " + newTime );
148+ if (!attrs .lastAccessTime ().equals (newTime ))
149+ throw new RuntimeException ("Last modified time "
150+ + attrs .lastModifiedTime ()
151+ + " != " + newTime );
152+ }
153+ } finally {
154+ Files .deleteIfExists (target );
155+ Files .deleteIfExists (symlink );
156+ }
157+ }
110158}
0 commit comments