Skip to content

Commit

Permalink
8330615: avoid signed integer overflows in zip_util.c readCen / hashN
Browse files Browse the repository at this point in the history 
Reviewed-by: lucy, mdoerr
  • Loading branch information
@MBaesken
MBaesken committed Apr 25, 2024
1 parent 4dfaa9b commit 5af6b45
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/java.base/share/native/libzip/zip_util.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ hash(const char *s)
static unsigned int
hashN(const char *s, int length)
{
int h = 0;
unsigned int h = 0;
while (length-- > 0)
h = 31*h + *s++;
return h;
Expand Down

7 comments on commit 5af6b45

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 5af6b45 May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch backport-MBaesken-5af6b45e in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 5af6b45e from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 25 Apr 2024 and was reviewed by Lutz Schmidt and Martin Doerr.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-MBaesken-5af6b45e:backport-MBaesken-5af6b45e
$ git checkout backport-MBaesken-5af6b45e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-MBaesken-5af6b45e

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk22u

@openjdk
Copy link

@openjdk openjdk bot commented on 5af6b45 May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch backport-MBaesken-5af6b45e in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 5af6b45e from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 25 Apr 2024 and was reviewed by Lutz Schmidt and Martin Doerr.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-MBaesken-5af6b45e:backport-MBaesken-5af6b45e
$ git checkout backport-MBaesken-5af6b45e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-MBaesken-5af6b45e

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 5af6b45 Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch backport-MBaesken-5af6b45e-master in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 5af6b45e from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 25 Apr 2024 and was reviewed by Lutz Schmidt and Martin Doerr.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-MBaesken-5af6b45e-master:backport-MBaesken-5af6b45e-master
$ git checkout backport-MBaesken-5af6b45e-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-MBaesken-5af6b45e-master

Please sign in to comment.