Skip to content
Permalink
Browse files
8274392: Suppress more warnings on non-serializable non-transient ins…
…tance fields in java.sql.rowset

Reviewed-by: bpb, lancea
  • Loading branch information
jddarcy committed Sep 27, 2021
1 parent 0865120 commit 5b660f3
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 5 deletions.
@@ -60,6 +60,7 @@ public class CachedRowSetImpl extends BaseRowSet implements RowSet, RowSetIntern
/**
* The <code>SyncProvider</code> used by the CachedRowSet
*/
@SuppressWarnings("serial")
private SyncProvider provider;

/**
@@ -68,6 +69,7 @@ public class CachedRowSetImpl extends BaseRowSet implements RowSet, RowSetIntern
* reader as part of its implementation.
* @serial
*/
@SuppressWarnings("serial")
private RowSetReader rowSetReader;

/**
@@ -76,6 +78,7 @@ public class CachedRowSetImpl extends BaseRowSet implements RowSet, RowSetIntern
* this writer as part of its implementation.
* @serial
*/
@SuppressWarnings("serial")
private RowSetWriter rowSetWriter;

/**
@@ -315,6 +318,7 @@ public class CachedRowSetImpl extends BaseRowSet implements RowSet, RowSetIntern
/**
* The field object for a transactional RowSet writer
*/
@SuppressWarnings("serial")
private TransactionalWriter tWriter = null;

protected transient JdbcRowSetResourceBundle resBundle;
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -47,6 +47,7 @@

public class FilteredRowSetImpl extends WebRowSetImpl implements Serializable, Cloneable, FilteredRowSet {

@SuppressWarnings("serial")
private Predicate p;

private boolean onInsertRow = false;
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2003, 2019, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -48,6 +48,7 @@ public class JdbcRowSetImpl extends BaseRowSet implements JdbcRowSet, Joinable {
* current connection to the database. This field is set
* internally when the connection is established.
*/
@SuppressWarnings("serial")
private Connection conn;

/**
@@ -56,6 +57,7 @@ public class JdbcRowSetImpl extends BaseRowSet implements JdbcRowSet, Joinable {
* {@code execute} creates the {@code PreparedStatement}
* object.
*/
@SuppressWarnings("serial")
private PreparedStatement ps;

/**
@@ -64,6 +66,7 @@ public class JdbcRowSetImpl extends BaseRowSet implements JdbcRowSet, Joinable {
* {@code execute} executes the rowset's command and thereby
* creates the rowset's {@code ResultSet} object.
*/
@SuppressWarnings("serial")
private ResultSet rs;

/**
@@ -80,6 +83,7 @@ public class JdbcRowSetImpl extends BaseRowSet implements JdbcRowSet, Joinable {
* {@code RowSetMetaDataImpl} is formed and which helps in getting
* the metadata information.
*/
@SuppressWarnings("serial")
private ResultSetMetaData resMD;


@@ -108,6 +108,7 @@ public class JoinRowSetImpl extends WebRowSetImpl implements JoinRowSet {
* object to leverage the properties and methods of a <code>WebRowSet</code>
* object.
*/
@SuppressWarnings("serial")
private WebRowSet wrs;


@@ -1,5 +1,5 @@
/*
* Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -68,6 +68,7 @@ public class WebRowSetImpl extends CachedRowSetImpl implements WebRowSet {
*/
private int curPosBfrWrite;

@SuppressWarnings("serial")
private SyncProvider provider;

/**
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -165,6 +165,7 @@ public class CachedRowSetWriter implements TransactionalWriter, Serializable {
*
* @serial
*/
@SuppressWarnings("serial")
private ResultSetMetaData callerMd;

/**
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2004, 2019, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2004, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -96,6 +96,7 @@ public class SyncResolverImpl extends CachedRowSetImpl implements SyncResolver {
* SyncResolver values. Synchronization takes place on a row by
* row basis encapsulated as a CahedRowSet.
*/
@SuppressWarnings("serial")
private CachedRowSet row;

private JdbcRowSetResourceBundle resBundle;

1 comment on commit 5b660f3

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.