Skip to content

Commit

Permalink
8307347: serviceability/sa/ClhsdbDumpclass.java could leave files own…
Browse files Browse the repository at this point in the history 
…ed by root on macOS

Reviewed-by: stuefe, cjplummer
  • Loading branch information
@ArnoZeller @RealCLanger
ArnoZeller authored and RealCLanger committed May 8, 2023
1 parent 89b7d07 commit 5c7ede9
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions test/hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import jdk.test.lib.apps.LingeredApp;
import jdk.test.lib.JDKToolLauncher;
import jdk.test.lib.process.OutputAnalyzer;
import jdk.test.lib.SA.SATestUtils;
import jtreg.SkippedException;

/**
Expand All @@ -47,6 +48,10 @@ public class ClhsdbDumpclass {
static final String APP_SLASH_CLASSNAME = APP_DOT_CLASSNAME.replace('.', '/');

public static void main(String[] args) throws Exception {
if (SATestUtils.needsPrivileges()) {
// This test will create a file as root that cannot be easily deleted, so don't run it.
throw new SkippedException("Cannot run this test on OSX if adding privileges is required.");
}
System.out.println("Starting ClhsdbDumpclass test");

LingeredApp theApp = null;
Expand Down

3 comments on commit 5c7ede9

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@ArnoZeller
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 5c7ede9 May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArnoZeller the backport was successfully created on the branch ArnoZeller-backport-5c7ede94 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 5c7ede94 from the openjdk/jdk repository.

The commit being backported was authored by Arno Zeller on 8 May 2023 and was reviewed by Thomas Stuefe and Chris Plummer.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git ArnoZeller-backport-5c7ede94:ArnoZeller-backport-5c7ede94
$ git checkout ArnoZeller-backport-5c7ede94
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git ArnoZeller-backport-5c7ede94

Please sign in to comment.