Skip to content

Commit

Permalink
8296931: NMT tests slowed down considerably by JDK-8242181
Browse files Browse the repository at this point in the history
Reviewed-by: chagedorn, mbaesken
  • Loading branch information
tstuefe committed Nov 16, 2022
1 parent 65f7de2 commit 5e08b3f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/hotspot/share/utilities/nativeCallStack.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ void NativeCallStack::print_on(outputStream* out, int indent) const {
address pc;
char buf[1024];
int offset;
int line_no;
if (is_empty()) {
for (int index = 0; index < indent; index ++) out->print(" ");
out->print("[BOOTSTRAP]");
Expand All @@ -96,9 +95,10 @@ void NativeCallStack::print_on(outputStream* out, int indent) const {
out->print("[" PTR_FORMAT "]", p2i(pc));
}

if (Decoder::get_source_info(pc, buf, sizeof(buf), &line_no, frame != 0)) {
out->print(" (%s:%d)", buf, line_no);
}
// Note: we deliberately omit printing source information here. NativeCallStack::print_on()
// can be called thousands of times as part of NMT detail reporting, and source printing
// can slow down reporting by a factor of 5 or more depending on platform (see JDK-8296931).

out->cr();
}
}
Expand Down

1 comment on commit 5e08b3f

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.