8362611: [GCC static analyzer] memory leak in ps_core.c core_handle_note

Korov · MBaesken · commit 644e400cd1f8 · 2025-07-21T12:24:49.000Z
Reviewed-by: dholmes, mbaesken
diff --git a/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c b/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c
@@ -286,7 +286,7 @@ static bool core_handle_note(struct ps_prochandle* ph, ELF_PHDR* note_phdr) {
       if (notep->n_type == NT_PRSTATUS) {
         if (core_handle_prstatus(ph, descdata, notep->n_descsz) != true) {
           print_error("failed to handle NT_PRSTATUS note\n");
-          return false;
+          goto err;
         }
       } else if (notep->n_type == NT_AUXV) {
         // Get first segment from entry point

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ static bool core_handle_note(struct ps_prochandle* ph, ELF_PHDR* note_phdr) {`
`286`	`286`	`if (notep->n_type == NT_PRSTATUS) {`
`287`	`287`	`if (core_handle_prstatus(ph, descdata, notep->n_descsz) != true) {`
`288`	`288`	`print_error("failed to handle NT_PRSTATUS note\n");`
`289`		`- return false;`
	`289`	`+ goto err;`
`290`	`290`	`}`
`291`	`291`	`} else if (notep->n_type == NT_AUXV) {`
`292`	`292`	`// Get first segment from entry point`