Skip to content

Commit

Permalink
8285094: Test java/awt/Frame/InvisibleOwner/InvisibleOwner.java faili…
Browse files Browse the repository at this point in the history
…ng on Linux

Reviewed-by: psadhukhan, serb
  • Loading branch information
prrace committed Apr 29, 2022
1 parent 573eace commit 64d98ba
Show file tree
Hide file tree
Showing 2 changed files with 128 additions and 64 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

/**
* @test
* @bug 8235638 8235739
* @bug 8235638 8235739 8285094
* @key headful
*/
public final class GetGraphicsStressTest {
Expand All @@ -44,6 +44,11 @@ public static void main(final String[] args) throws Exception {
endtime = System.nanoTime() + TimeUnit.SECONDS.toNanos(5);
test();
}
/*
* This test needs to give the desktop time to recover to avoid
* destabilising other tests.
*/
Thread.sleep(10000);
}

private static void test() throws Exception {
Expand Down
185 changes: 122 additions & 63 deletions test/jdk/java/awt/Frame/InvisibleOwner/InvisibleOwner.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2012, 2016, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -24,99 +24,158 @@
/*
@test
@key headful
@bug 7154177
@bug 7154177 8285094
@summary An invisible owner frame should never become visible
@author anthony.petrov@oracle.com: area=awt.toplevel
@library ../../regtesthelpers
@build Util
@run main InvisibleOwner
*/

import java.awt.*;
import java.awt.event.*;
import java.util.*;
import test.java.awt.regtesthelpers.Util;
import java.awt.Color;
import java.awt.EventQueue;
import java.awt.Frame;
import java.awt.Rectangle;
import java.awt.Robot;
import java.awt.Toolkit;
import java.awt.Window;
import java.awt.event.InputEvent;
import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;

public class InvisibleOwner {

private static volatile boolean invisibleOwnerClicked = false;
private static volatile boolean backgroundClicked = false;

private static final int F_X = 40, F_Y = 40, F_W = 200, F_H = 200;
private static final int F_X = 200, F_Y = 200, F_W = 200, F_H = 200;
private static final int H_X = F_X - 10, H_Y = F_Y - 10, H_W = F_W + 20, H_H = F_H + 20;
private static final int C_X = F_X + F_W / 2, C_Y = F_Y + F_H / 2;
static final Color helperFrameBgColor = Color.blue;
static final Color invisibleFrameBgColor = Color.green;
static Frame invisibleFrame;
static Frame helperFrame;
static Window ownedWindow;
static Robot robot;

public static void main(String[] args) throws AWTException {
// A background frame to compare a pixel color against
Frame helperFrame = new Frame("Background frame");
helperFrame.setBackground(Color.BLUE);
helperFrame.setBounds(F_X - 10, F_Y - 10, F_W + 20, F_H + 20);
static void createUI() {
/* A background frame to compare a pixel color against
* It should be centered in the same location as the invisible
* frame but extend beyond its bounds.
*/
helperFrame = new Frame("Background frame");
helperFrame.setBackground(helperFrameBgColor);
helperFrame.setLocation(H_X, H_Y);
helperFrame.setSize(H_W, H_H);
System.out.println("Helper requested bounds : x=" +
H_X + " y="+ H_Y +" w="+ H_W +" h="+ H_H);
helperFrame.addMouseListener(new MouseAdapter() {
@Override
public void mouseClicked(MouseEvent ev) {
backgroundClicked= true;
System.out.println("Background helper frame clicked");
backgroundClicked = true;
}
});
helperFrame.setVisible(true);

// An owner frame that should stay invisible
Frame frame = new Frame("Invisible Frame");
frame.setBackground(Color.GREEN);
frame.setLocation(F_X, F_Y);
frame.setSize(F_W, F_H);
frame.addMouseListener(new MouseAdapter() {
/* An owner frame that should stay invisible but theoretical
* bounds are within the helper frame.
*/
invisibleFrame = new Frame("Invisible Frame");
invisibleFrame.setBackground(invisibleFrameBgColor);
invisibleFrame.setLocation(F_X, F_Y);
invisibleFrame.setSize(F_W, F_H);
invisibleFrame.addMouseListener(new MouseAdapter() {
@Override
public void mouseClicked(MouseEvent ev) {
System.out.println("Invisible owner clicked");
invisibleOwnerClicked = true;
}
});

// An owned window
final Window window = new Window(frame);
window.setBackground(Color.RED);
window.setSize(200, 200);
window.setLocation(300, 300);
window.setVisible(true);
try { Thread.sleep(1000); } catch (Exception ex) {}
/* An owned window of the invisible frame that is located
* such that it does not overlap either the helper or
* the invisisible frame.
*/
ownedWindow = new Window(invisibleFrame);
ownedWindow.setBackground(Color.RED);
ownedWindow.setLocation(H_X+H_W+100, H_Y+H_W+100);
ownedWindow.setSize(100, 100);
ownedWindow.setVisible(true);

Robot robot = new Robot();
Toolkit.getDefaultToolkit().sync();
}

// Clicking the owned window shouldn't make its owner visible
Util.clickOnComp(window, robot);
try { Thread.sleep(500); } catch (Exception ex) {}
static void captureScreen() throws Exception {
System.out.println("Writing screen capture");
Rectangle screenRect = helperFrame.getGraphicsConfiguration().getBounds();
java.awt.image.BufferedImage bi = robot.createScreenCapture(screenRect);
javax.imageio.ImageIO.write(bi, "png", new java.io.File("screen_IO.png"));
}

public static void main(String[] args) throws Exception {

// Assume the location and size are applied to the frame as expected.
// This should work fine on the Mac. We can't call getLocationOnScreen()
// since from Java perspective the frame is invisible anyway.
try {
EventQueue.invokeAndWait(() -> createUI());
robot = new Robot();
robot.waitForIdle();
robot.setAutoDelay(100);
robot.setAutoWaitForIdle(true);

// 1. Check the color at the center of the owner frame
Color c = robot.getPixelColor(F_X + F_W / 2, F_Y + F_H / 2);
System.err.println("Pixel color: " + c);
if (c == null) {
throw new RuntimeException("Robot.getPixelColor() failed");
}
if (c.equals(frame.getBackground())) {
throw new RuntimeException("The invisible frame has become visible");
}
if (!c.equals(helperFrame.getBackground())) {
throw new RuntimeException("The background helper frame has been covered by something unexpected");
}
Rectangle helperBounds = helperFrame.getBounds();
System.out.println("helperFrame bounds = " + helperBounds);
if (!helperBounds.contains(C_X, C_Y)) {
System.out.println("Helper not positioned where it needs to be");
return;
}

// 2. Try to click it
robot.mouseMove(F_X + F_W / 2, F_Y + F_H / 2);
robot.mousePress(InputEvent.BUTTON1_MASK);
robot.mouseRelease(InputEvent.BUTTON1_MASK);
try { Thread.sleep(500); } catch (Exception ex) {}
// Clicking the owned window shouldn't make its owner visible
Rectangle ownedWindowBounds = ownedWindow.getBounds();
robot.mouseMove(ownedWindowBounds.x + ownedWindowBounds.width / 2,
ownedWindowBounds.y + ownedWindowBounds.height / 2);
robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
robot.delay(1000);

// Cleanup
window.dispose();
frame.dispose();
helperFrame.dispose();
// 1. Check the color at the center of the invisible & helper frame location
Color c = robot.getPixelColor(C_X, C_Y);
System.out.println("Sampled pixel at " + C_X +"," + C_Y);
System.out.println("Pixel color: " + c);
if (c == null) {
captureScreen();
throw new RuntimeException("Robot.getPixelColor() failed");
}
if (c.equals(invisibleFrameBgColor)) {
captureScreen();
throw new RuntimeException("The invisible frame has become visible");
}
if (!c.equals(helperFrameBgColor)) {
captureScreen();
throw new RuntimeException(
"Background frame was covered by something unexpected");
}

// Final checks
if (invisibleOwnerClicked) {
throw new RuntimeException("An invisible owner frame got clicked. Looks like it became visible.");
}
if (!backgroundClicked) {
throw new RuntimeException("The background helper frame hasn't been clciked");
// 2. Try to click it - event should be delivered to the
// helper frame, not the invisible frame.
robot.mouseMove(C_X, C_Y);
robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
robot.delay(1000);

if (invisibleOwnerClicked) {
captureScreen();
throw new RuntimeException(
"The invisible owner frame got clicked. Looks like it became visible.");
}
if (!backgroundClicked) {
captureScreen();
throw new RuntimeException(
"The background helper frame hasn't been clicked");
}
} finally {
EventQueue.invokeAndWait(() -> {
if (ownedWindow != null) ownedWindow.dispose();
if (invisibleFrame != null) invisibleFrame.dispose();
if (helperFrame != null) helperFrame.dispose();
});
}

}
}

1 comment on commit 64d98ba

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.