Skip to content

Commit

Permalink
8280948: [TESTBUG] Write a regression test for JDK-4659800
Browse files Browse the repository at this point in the history
Reviewed-by: aivanov
  • Loading branch information
Manukumar V S authored and aivanov-jdk committed Feb 4, 2022
1 parent 7207f2a commit 66b2c3b
Showing 1 changed file with 124 additions and 0 deletions.
124 changes: 124 additions & 0 deletions test/jdk/javax/swing/JButton/4659800/EnterKeyActivatesButton.java
@@ -0,0 +1,124 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

import java.awt.event.KeyEvent;
import java.awt.Robot;
import java.util.Arrays;
import java.util.List;

import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.SwingUtilities;
import javax.swing.UIManager;
import javax.swing.UnsupportedLookAndFeelException;

import static java.util.stream.Collectors.toList;

/*
* @test
* @key headful
* @requires (os.family == "windows")
* @bug 4659800
* @summary Check whether pressing <Enter> key generates
* ActionEvent on focused Button or not. This is applicable only for
* WindowsLookAndFeel and WindowsClassicLookAndFeel.
* @run main EnterKeyActivatesButton
*/
public class EnterKeyActivatesButton {
private static volatile boolean buttonPressed;
private static JFrame frame;

public static void main(String[] s) throws Exception {
runTest();
}

private static void setLookAndFeel(String lafName) {
try {
UIManager.setLookAndFeel(lafName);
} catch (UnsupportedLookAndFeelException ignored) {
System.out.println("Ignoring Unsupported L&F: " + lafName);
} catch (ClassNotFoundException | InstantiationException
| IllegalAccessException e) {
throw new RuntimeException(e);
}
}

private static void disposeFrame() {
if (frame != null) {
frame.dispose();
frame = null;
}
}

private static void createUI() {
frame = new JFrame();
JPanel panel = new JPanel();
JButton focusedButton = new JButton("Button1");
focusedButton.addActionListener(e -> buttonPressed = true);
panel.add(focusedButton);
panel.add(new JButton("Button2"));
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.add(panel);
frame.pack();
frame.setLocationRelativeTo(null);
frame.setVisible(true);
focusedButton.requestFocusInWindow();
}

public static void runTest() throws Exception {
Robot robot = new Robot();
robot.setAutoDelay(100);
// Consider only Windows and Windows Classic LnFs.
List<String> winlafs = Arrays.stream(UIManager.getInstalledLookAndFeels())
.filter(laf -> laf.getName().startsWith("Windows"))
.map(laf -> laf.getClassName())
.collect(toList());

for (String laf : winlafs) {
try {
buttonPressed = false;
System.out.println("Testing L&F: " + laf);
SwingUtilities.invokeAndWait(() -> {
setLookAndFeel(laf);
createUI();
});

robot.waitForIdle();
robot.keyPress(KeyEvent.VK_ENTER);
robot.keyRelease(KeyEvent.VK_ENTER);
robot.waitForIdle();

if (buttonPressed) {
System.out.println("Test Passed for L&F: " + laf);
} else {
throw new RuntimeException("Test Failed, button not pressed for L&F: " + laf);
}

} finally {
SwingUtilities.invokeAndWait(EnterKeyActivatesButton::disposeFrame);
}
}

}
}

5 comments on commit 66b2c3b

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rudometov
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@Rudometov
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 66b2c3b Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rudometov the backport was successfully created on the branch Rudometov-backport-66b2c3b6 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 66b2c3b6 from the openjdk/jdk repository.

The commit being backported was authored by Manukumar V S on 4 Feb 2022 and was reviewed by Alexey Ivanov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev Rudometov-backport-66b2c3b6:Rudometov-backport-66b2c3b6
$ git checkout Rudometov-backport-66b2c3b6
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev Rudometov-backport-66b2c3b6

@openjdk
Copy link

@openjdk openjdk bot commented on 66b2c3b Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rudometov the backport was successfully created on the branch Rudometov-backport-66b2c3b6 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 66b2c3b6 from the openjdk/jdk repository.

The commit being backported was authored by Manukumar V S on 4 Feb 2022 and was reviewed by Alexey Ivanov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev Rudometov-backport-66b2c3b6:Rudometov-backport-66b2c3b6
$ git checkout Rudometov-backport-66b2c3b6
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev Rudometov-backport-66b2c3b6

Please sign in to comment.