Skip to content

Commit 671dfba

Browse files
jaikiranLance Andersen
authored andcommitted
6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
Reviewed-by: lancea, alanb
1 parent e5866aa commit 671dfba

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/java.base/share/classes/java/util/jar/JarFile.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,9 @@ private Manifest getManifestFromReference() throws IOException {
423423
}
424424
man = new Manifest(jv, new ByteArrayInputStream(b), getName());
425425
} else {
426-
man = new Manifest(super.getInputStream(manEntry), getName());
426+
try (InputStream is = super.getInputStream(manEntry)) {
427+
man = new Manifest(is, getName());
428+
}
427429
}
428430
manRef = new SoftReference<>(man);
429431
}

0 commit comments

Comments
 (0)