Skip to content

Commit

Permalink
8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) fa…
Browse files Browse the repository at this point in the history
…iled: no exit test

Reviewed-by: roland, thartmann, qamai
  • Loading branch information
chhagedorn committed Jan 19, 2024
1 parent 16be388 commit 6997bfc
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/hotspot/share/opto/subnode.cpp
Expand Up @@ -155,7 +155,7 @@ static bool ok_to_convert(Node* inc, Node* var) {
static bool is_cloop_condition(BoolNode* bol) {
for (DUIterator_Fast imax, i = bol->fast_outs(imax); i < imax; i++) {
Node* out = bol->fast_out(i);
if (out->is_CountedLoopEnd()) {
if (out->is_BaseCountedLoopEnd()) {
return true;
}
}
Expand Down
@@ -0,0 +1,49 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
package compiler.c2;

/*
* @test
* @bug 8323154
* @summary Long counted loop exit check should not be transformed into an unsigned check
*
* @run main/othervm -Xbatch -XX:CompileCommand=compileonly,compiler.c2.TestMinValueStrideLongCountedLoop::test
* compiler.c2.TestMinValueStrideLongCountedLoop
*/

public class TestMinValueStrideLongCountedLoop {
static long limit = 0;
static long res = 0;

public static void main(String[] args) {
for (int i = 0; i < 10000; i++) {
test();
}
}

static void test() {
for (long i = 0; i >= limit + (Long.MIN_VALUE + 1); i += Long.MIN_VALUE) {
res += 42;
}
}
}

1 comment on commit 6997bfc

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.