Skip to content

Commit

Permalink
8283056: show abstract machine code in hs-err for all VM crashes
Browse files Browse the repository at this point in the history 
Reviewed-by: thartmann, dholmes
  • Loading branch information
Doug Simon committed Mar 17, 2022
1 parent bad658e commit 69e4e33
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/hotspot/share/utilities/vmError.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ void VMError::report(outputStream* st, bool _verbose) {

STEP("printing code blobs if possible")

if (_verbose && _context) {
if (_verbose) {
const int printed_capacity = max_error_log_print_code;
address printed[printed_capacity];
printed[0] = nullptr;
Expand All @@ -929,7 +929,8 @@ void VMError::report(outputStream* st, bool _verbose) {
printed_len++;
}
} else {
frame fr = os::fetch_frame_from_context(_context);
frame fr = _context ? os::fetch_frame_from_context(_context)
: os::current_frame();
while (printed_len < limit && fr.pc() != nullptr) {
if (print_code(st, _thread, fr.pc(), fr.pc() == _pc, printed, printed_capacity)) {
printed_len++;
Expand Down

3 comments on commit 69e4e33

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@TheRealMDoerr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 69e4e33 Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealMDoerr the backport was successfully created on the branch TheRealMDoerr-backport-69e4e338 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 69e4e338 from the openjdk/jdk repository.

The commit being backported was authored by Doug Simon on 17 Mar 2022 and was reviewed by Tobias Hartmann and David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git TheRealMDoerr-backport-69e4e338:TheRealMDoerr-backport-69e4e338
$ git checkout TheRealMDoerr-backport-69e4e338
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git TheRealMDoerr-backport-69e4e338

Please sign in to comment.