Skip to content

Commit

Permalink
8159927: Add a test to verify JMOD files created in the images do not…
Browse files Browse the repository at this point in the history
… have debug symbols

Reviewed-by: jlaskey
  • Loading branch information
Mandy Chung committed Jan 19, 2024
1 parent 437342b commit 6c0bebc
Showing 1 changed file with 76 additions and 0 deletions.
76 changes: 76 additions & 0 deletions test/jdk/jdk/modules/etc/JmodExcludedFiles.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/**
* @test
* @bug 8159927
* @modules java.base/jdk.internal.util
* @run main JmodExcludedFiles
* @summary Test that JDK JMOD files do not include native debug symbols
*/

import java.nio.file.DirectoryStream;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;
import jdk.internal.util.OperatingSystem;

public class JmodExcludedFiles {
public static void main(String[] args) throws Exception {
String javaHome = System.getProperty("java.home");
Path jmods = Path.of(javaHome, "jmods");
try (DirectoryStream<Path> stream = Files.newDirectoryStream(jmods, "*.jmod")) {
for (Path jmodFile : stream) {
try (ZipFile zip = new ZipFile(jmodFile.toFile())) {
if (zip.stream().map(ZipEntry::getName)
.anyMatch(JmodExcludedFiles::isNativeDebugSymbol)) {
throw new RuntimeException(jmodFile + " is expected not to include native debug symbols");
}
}
}
}
}

private static boolean isNativeDebugSymbol(String name) {
int index = name.indexOf("/");
if (index < 0) {
throw new RuntimeException("unexpected entry name: " + name);
}
String section = name.substring(0, index);
if (section.equals("lib") || section.equals("bin")) {
if (OperatingSystem.isMacOS()) {
String n = name.substring(index+1);
int i = n.indexOf("/");
if (i != -1) {
return n.substring(0, i).endsWith(".dSYM");
}
}
return name.endsWith(".diz")
|| name.endsWith(".debuginfo")
|| name.endsWith(".map")
|| name.endsWith(".pdb");
}
return false;
}
}

3 comments on commit 6c0bebc

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SoniaZaldana
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 6c0bebc Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SoniaZaldana the backport was successfully created on the branch backport-SoniaZaldana-6c0bebcc in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6c0bebcc from the openjdk/jdk repository.

The commit being backported was authored by Mandy Chung on 19 Jan 2024 and was reviewed by Jim Laskey.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-SoniaZaldana-6c0bebcc:backport-SoniaZaldana-6c0bebcc
$ git checkout backport-SoniaZaldana-6c0bebcc
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-SoniaZaldana-6c0bebcc

Please sign in to comment.