Skip to content

Commit 6cd166a

Browse files
committed
8309403: Serial: Remove the useless adaptive size policy in GenCollectedHeap
Reviewed-by: ayang, tschatzl
1 parent 5d5ae35 commit 6cd166a

File tree

6 files changed

+8
-118
lines changed

6 files changed

+8
-118
lines changed

src/hotspot/share/gc/serial/defNewGeneration.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -830,10 +830,6 @@ void DefNewGeneration::collect(bool full,
830830

831831
adjust_desired_tenuring_threshold();
832832

833-
// A successful scavenge should restart the GC time limit count which is
834-
// for full GC's.
835-
AdaptiveSizePolicy* size_policy = heap->size_policy();
836-
size_policy->reset_gc_overhead_limit_count();
837833
assert(!heap->incremental_collection_failed(), "Should be clear");
838834
} else {
839835
assert(_promo_failure_scan_stack.is_empty(), "post condition");

src/hotspot/share/gc/shared/genCollectedHeap.cpp

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ GenCollectedHeap::GenCollectedHeap(Generation::Name young,
9595
MaxOldSize,
9696
GenAlignment)),
9797
_rem_set(nullptr),
98-
_soft_ref_gen_policy(),
99-
_size_policy(nullptr),
98+
_soft_ref_policy(),
10099
_gc_policy_counters(new GCPolicyCounters(policy_counters_name, 2, 2)),
101100
_incremental_collection_failed(false),
102101
_full_collections_completed(0),
@@ -139,17 +138,6 @@ CardTableRS* GenCollectedHeap::create_rem_set(const MemRegion& reserved_region)
139138
return new CardTableRS(reserved_region);
140139
}
141140

142-
void GenCollectedHeap::initialize_size_policy(size_t init_eden_size,
143-
size_t init_promo_size,
144-
size_t init_survivor_size) {
145-
const double max_gc_pause_sec = ((double) MaxGCPauseMillis) / 1000.0;
146-
_size_policy = new AdaptiveSizePolicy(init_eden_size,
147-
init_promo_size,
148-
init_survivor_size,
149-
max_gc_pause_sec,
150-
GCTimeRatio);
151-
}
152-
153141
ReservedHeapSpace GenCollectedHeap::allocate(size_t alignment) {
154142
// Now figure out the total size.
155143
const size_t pageSize = UseLargePages ? os::large_page_size() : os::vm_page_size();
@@ -194,10 +182,6 @@ void GenCollectedHeap::post_initialize() {
194182

195183
def_new_gen->ref_processor_init();
196184

197-
initialize_size_policy(def_new_gen->eden()->capacity(),
198-
_old_gen->capacity(),
199-
def_new_gen->from()->capacity());
200-
201185
MarkSweep::initialize();
202186

203187
ScavengableNMethods::initialize(&_is_scavengable);

src/hotspot/share/gc/shared/genCollectedHeap.hpp

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
#include "gc/shared/generation.hpp"
3030
#include "gc/shared/oopStorageParState.hpp"
3131
#include "gc/shared/preGCValues.hpp"
32-
#include "gc/shared/softRefGenPolicy.hpp"
32+
#include "gc/shared/softRefPolicy.hpp"
3333

3434
class AdaptiveSizePolicy;
3535
class CardTableRS;
@@ -72,10 +72,7 @@ class GenCollectedHeap : public CollectedHeap {
7272
// The singleton CardTable Remembered Set.
7373
CardTableRS* _rem_set;
7474

75-
SoftRefGenPolicy _soft_ref_gen_policy;
76-
77-
// The sizing of the heap is controlled by a sizing policy.
78-
AdaptiveSizePolicy* _size_policy;
75+
SoftRefPolicy _soft_ref_policy;
7976

8077
GCPolicyCounters* _gc_policy_counters;
8178

@@ -139,10 +136,6 @@ class GenCollectedHeap : public CollectedHeap {
139136
jint initialize() override;
140137
virtual CardTableRS* create_rem_set(const MemRegion& reserved_region);
141138

142-
void initialize_size_policy(size_t init_eden_size,
143-
size_t init_promo_size,
144-
size_t init_survivor_size);
145-
146139
// Does operations required after initialization has been done.
147140
void post_initialize() override;
148141

@@ -158,12 +151,7 @@ class GenCollectedHeap : public CollectedHeap {
158151
GenerationSpec* young_gen_spec() const;
159152
GenerationSpec* old_gen_spec() const;
160153

161-
SoftRefPolicy* soft_ref_policy() override { return &_soft_ref_gen_policy; }
162-
163-
// Adaptive size policy
164-
virtual AdaptiveSizePolicy* size_policy() {
165-
return _size_policy;
166-
}
154+
SoftRefPolicy* soft_ref_policy() override { return &_soft_ref_policy; }
167155

168156
// Performance Counter support
169157
GCPolicyCounters* counters() { return _gc_policy_counters; }

src/hotspot/share/gc/shared/softRefGenPolicy.cpp

Lines changed: 0 additions & 40 deletions
This file was deleted.

src/hotspot/share/gc/shared/softRefGenPolicy.hpp

Lines changed: 0 additions & 38 deletions
This file was deleted.

src/hotspot/share/prims/whitebox.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1445,12 +1445,12 @@ WB_END
14451445
WB_ENTRY(void, WB_FullGC(JNIEnv* env, jobject o))
14461446
Universe::heap()->soft_ref_policy()->set_should_clear_all_soft_refs(true);
14471447
Universe::heap()->collect(GCCause::_wb_full_gc);
1448-
#if INCLUDE_G1GC
1449-
if (UseG1GC) {
1450-
// Needs to be cleared explicitly for G1
1448+
#if INCLUDE_G1GC || INCLUDE_SERIALGC
1449+
if (UseG1GC || UseSerialGC) {
1450+
// Needs to be cleared explicitly for G1 and Serial GC.
14511451
Universe::heap()->soft_ref_policy()->set_should_clear_all_soft_refs(false);
14521452
}
1453-
#endif // INCLUDE_G1GC
1453+
#endif // INCLUDE_G1GC || INCLUDE_SERIALGC
14541454
WB_END
14551455

14561456
WB_ENTRY(void, WB_YoungGC(JNIEnv* env, jobject o))

0 commit comments

Comments
 (0)