8313258: RuntimeInvisibleTypeAnnotationsAttribute.annotations() API Index out of Bound error

Reviewed-by: briangoetz

Author: asotona

src/java.base/share/classes/jdk/internal/classfile/impl/CodeImpl.java

@@ -97,6 +97,9 @@ public void setLabelTarget(Label label, int bci) {
 
     @Override
     public Label getLabel(int bci) {
+        if (bci < 0 || bci > codeLength)
+            throw new IllegalArgumentException(String.format("Bytecode offset out of range; bci=%d, codeLength=%d",
+                                                             bci, codeLength));
         if (labels == null)
             labels = new LabelImpl[codeLength + 1];
         LabelImpl l = labels[bci];

test/jdk/jdk/classfile/LimitsTest.java

@@ -30,6 +30,7 @@
 import java.lang.constant.ConstantDescs;
 import java.lang.constant.MethodTypeDesc;
 import jdk.internal.classfile.Classfile;
+import jdk.internal.classfile.impl.LabelContext;
 import org.junit.jupiter.api.Test;
 import static org.junit.jupiter.api.Assertions.*;
 
@@ -69,4 +70,13 @@ void testEmptyCode() {
         assertThrows(IllegalArgumentException.class, () -> Classfile.of().build(ClassDesc.of("EmptyClass"), cb -> cb.withMethodBody(
                 "emptyMethod", MethodTypeDesc.of(ConstantDescs.CD_void), 0, cob -> {})));
     }
+
+    @Test
+    void testCodeRange() {
+        var cf = Classfile.of();
+        var lc = (LabelContext)cf.parse(cf.build(ClassDesc.of("EmptyClass"), cb -> cb.withMethodBody(
+                "aMethod", MethodTypeDesc.of(ConstantDescs.CD_void), 0, cob -> cob.return_()))).methods().get(0).code().get();
+        assertThrows(IllegalArgumentException.class, () -> lc.getLabel(-1));
+        assertThrows(IllegalArgumentException.class, () -> lc.getLabel(10));
+    }
 }