Skip to content

Commit

Permalink
8328064: Remove obsolete comments in constantPool and metadataFactory
Browse files Browse the repository at this point in the history
Reviewed-by: coleenp
  • Loading branch information
linade authored and D-D-H committed Mar 14, 2024
1 parent 7502dc9 commit 6f2676d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions src/hotspot/share/memory/metadataFactory.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ class MetadataFactory : AllStatic {
public:
template <typename T>
static Array<T>* new_array(ClassLoaderData* loader_data, int length, TRAPS) {
// The "true" argument is because all metadata arrays are read only when
// dumped to the shared archive
return new (loader_data, length, THREAD) Array<T>(length);
}

Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/oops/constantPool.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ void ConstantPool::metaspace_pointers_do(MetaspaceClosure* it) {

for (int i = 0; i < length(); i++) {
// The only MSO's embedded in the CP entries are Symbols:
// JVM_CONSTANT_String (normal and pseudo)
// JVM_CONSTANT_String
// JVM_CONSTANT_Utf8
constantTag ctag = tag_at(i);
if (ctag.is_string() || ctag.is_utf8()) {
Expand Down

3 comments on commit 6f2676d

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesperIRL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tag jdk-23+14

@openjdk
Copy link

@openjdk openjdk bot commented on 6f2676d Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesperIRL The tag jdk-23+14 was successfully created.

Please sign in to comment.