-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8296318: use-def assert: special case undetected loops nested in infi…
…nite loops Reviewed-by: chagedorn, kvn
- Loading branch information
Showing
5 changed files
with
115 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
test/hotspot/jtreg/compiler/loopopts/TestUndetectedLoopInInfiniteLoop.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
/* | ||
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/* | ||
* @test | ||
* @bug 8296318 | ||
* @summary Loops inside infinite loops may not be detected, thus a region may still | ||
* be the loop head, even if it is not a LoopNode. | ||
* @run main/othervm -Xcomp -XX:-TieredCompilation | ||
* -XX:CompileCommand=compileonly,TestUndetectedLoopInInfiniteLoop::test* | ||
* -XX:PerMethodTrapLimit=0 | ||
* TestUndetectedLoopInInfiniteLoop | ||
*/ | ||
|
||
|
||
public class TestUndetectedLoopInInfiniteLoop { | ||
public static void main (String[] args) { | ||
test(true, false); | ||
} | ||
public static void test(boolean flag, boolean flag2) { | ||
int x = 0; | ||
if (flag2) { // runtime check, avoid infinite loop | ||
while (true) { // infinite loop (no exit) | ||
if (flag) { | ||
x++; | ||
} | ||
do { // inner loop | ||
// assert for this block | ||
// Region | ||
// Phi -> SubI -> XorI ---> Phi | ||
x = (x - 1) ^ 1; | ||
// Problem: this looks like a loop, but we have no LoopNode | ||
// We have no LoopNode, because this is all in an infinite | ||
// loop, and during PhaseIdealLoop::build_loop_tree we do not | ||
// attach the loops of an infinite loop to the loop tree, | ||
// and hence we do not get to call beautify_loop on these loops | ||
// which would have turned the Region into a LoopNode. | ||
} while (x < 0); | ||
} | ||
} | ||
} | ||
} |
736fcd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues
736fcd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/backport jdk17u-dev
736fcd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GoeLin the backport was successfully created on the branch GoeLin-backport-736fcd49 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:
➡️ Create pull request
The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev: