Skip to content
Permalink
Browse files
8268542: serviceability/logging/TestFullNames.java tests only 1st tes…
…t case

Reviewed-by: sspitsyn
  • Loading branch information
iignatev committed Jun 10, 2021
1 parent a95e64c commit 74007890bb9a3fa3a65683a3f480e399f2b1a0b6
Showing 1 changed file with 2 additions and 1 deletion.
@@ -61,14 +61,15 @@ public static void main(String[] args) throws Exception {
fileName
};
for (String logOutput : validOutputs) {
Asserts.assertFalse(file.exists());
// Run with logging=trace on stdout so that we can verify the log configuration afterwards.
ProcessBuilder pb = ProcessTools.createJavaProcessBuilder("-Xlog:logging=trace",
"-Xlog:all=trace:" + logOutput,
"-version");
OutputAnalyzer output = new OutputAnalyzer(pb.start());
output.shouldHaveExitValue(0);
Asserts.assertTrue(file.exists());
file.deleteOnExit(); // Clean up after test
file.delete();
output.shouldMatch("\\[logging *\\].*" + baseName); // Expect to see the log output listed
}
}

5 comments on commit 7400789

@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented on 7400789 Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 7400789 Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 7400789 Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-74007890 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 74007890 from the openjdk/jdk repository.

The commit being backported was authored by Igor Ignatyev on 10 Jun 2021 and was reviewed by Serguei Spitsyn.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-74007890:GoeLin-backport-74007890
$ git checkout GoeLin-backport-74007890
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-74007890

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 7400789 Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 7400789 Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-74007890 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 74007890 from the openjdk/jdk repository.

The commit being backported was authored by Igor Ignatyev on 10 Jun 2021 and was reviewed by Serguei Spitsyn.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-74007890:GoeLin-backport-74007890
$ git checkout GoeLin-backport-74007890
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-74007890

Please sign in to comment.