Skip to content

Commit 76ff978

Browse files
committed
8354510: Skipped gtest cause test failure
Reviewed-by: rehn, erikj
1 parent c7b70a1 commit 76ff978

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

make/RunTests.gmk

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -534,22 +534,21 @@ define SetupRunGtestTestBody
534534
$$(eval $1_PASSED := $$(shell $$(AWK) '/\[ PASSED \] .* tests?./ \
535535
{ print $$$$4 }' $$($1_RESULT_FILE))) \
536536
$$(if $$($1_PASSED), , $$(eval $1_PASSED := 0)) \
537-
$$(eval $1_SKIPPED := $$(shell $$(AWK) \
538-
'/YOU HAVE [0-9]+ DISABLED TEST/ { \
539-
if (match($$$$0, /[0-9]+/, arr)) { \
540-
print arr[0]; \
541-
found=1; \
542-
} \
543-
} \
544-
END { if (!found) print 0; }' \
545-
$$($1_RESULT_FILE))) \
537+
$$(eval $1_GTEST_DISABLED := $$(shell $$(AWK) '/YOU HAVE .* DISABLED TEST/ \
538+
{ print $$$$3 }' $$($1_RESULT_FILE))) \
539+
$$(if $$($1_GTEST_DISABLED), , $$(eval $1_GTEST_DISABLED := 0)) \
540+
$$(eval $1_GTEST_SKIPPED := $$(shell $$(AWK) '/\[ SKIPPED \] .* tests?.*/ \
541+
{ print $$$$4 }' $$($1_RESULT_FILE))) \
542+
$$(if $$($1_GTEST_SKIPPED), , $$(eval $1_GTEST_SKIPPED := 0)) \
543+
$$(eval $1_SKIPPED := $$(shell \
544+
$$(EXPR) $$($1_GTEST_DISABLED) + $$($1_GTEST_SKIPPED))) \
546545
$$(eval $1_FAILED := $$(shell $$(AWK) '/\[ FAILED \] .* tests?, \
547546
listed below/ { print $$$$4 }' $$($1_RESULT_FILE))) \
548547
$$(if $$($1_FAILED), , $$(eval $1_FAILED := 0)) \
549548
$$(eval $1_ERROR := $$(shell \
550-
$$(EXPR) $$($1_RUN) - $$($1_PASSED) - $$($1_FAILED))) \
549+
$$(EXPR) $$($1_RUN) - $$($1_PASSED) - $$($1_FAILED) - $$($1_GTEST_SKIPPED))) \
551550
$$(eval $1_TOTAL := $$(shell \
552-
$$(EXPR) $$($1_RUN) + $$($1_SKIPPED))) \
551+
$$(EXPR) $$($1_RUN) + $$($1_GTEST_DISABLED))) \
553552
, \
554553
$$(eval $1_PASSED := 0) \
555554
$$(eval $1_FAILED := 0) \

0 commit comments

Comments
 (0)