Skip to content

Commit

Permalink
8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "As…
Browse files Browse the repository at this point in the history 
…sertionError: Expected IOException to be thrown, but nothing was thrown"

Reviewed-by: lancea
  • Loading branch information
Ravi Reddy authored and Lance Andersen committed Apr 12, 2022
1 parent 19b140a commit 7891085
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/jdk/java/util/zip/CloseInflaterDeflaterTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

/**
* @test
* @bug 8193682 8278794
* @bug 8193682 8278794 8284771
* @summary Test Infinite loop while writing on closed Deflater and Inflater.
* @run testng CloseInflaterDeflaterTest
*/
Expand Down Expand Up @@ -171,10 +171,11 @@ public void testDeflaterInputStream() throws IOException {
/**
* Test for infinite loop by writing bytes to closed InflaterOutputStream
*
* Note: Disabling this test as it is failing intermittently.
* @param useCloseMethod indicates whether to use Close() or finish() method
* @throws IOException if an error occurs
*/
@Test(dataProvider = "testOutputStreams")
@Test(dataProvider = "testOutputStreams",enabled=false)
public void testInflaterOutputStream(boolean useCloseMethod) throws IOException {
InflaterOutputStream inf = new InflaterOutputStream(outStream);
assertThrows(IOException.class , () -> inf.write(inputBytes, 0, INPUT_LENGTH));
Expand Down

3 comments on commit 7891085

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 7891085 Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 7891085 Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-7891085a in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 7891085a from the openjdk/jdk repository.

The commit being backported was authored by Ravi Reddy on 12 Apr 2022 and was reviewed by Lance Andersen.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-7891085a:GoeLin-backport-7891085a
$ git checkout GoeLin-backport-7891085a
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-7891085a

Please sign in to comment.