Skip to content

Commit

Permalink
8284944: assert(cnt++ < 40) failed: infinite cycle in loop optimization
Browse files Browse the repository at this point in the history
Reviewed-by: kvn, chagedorn
  • Loading branch information
tobiasholenstein authored and chhagedorn committed May 25, 2022
1 parent e534c13 commit 796494d
Show file tree
Hide file tree
Showing 2 changed files with 125 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/hotspot/share/opto/compile.cpp
Expand Up @@ -2059,10 +2059,8 @@ void Compile::process_late_inline_calls_no_inline(PhaseIterGVN& igvn) {

bool Compile::optimize_loops(PhaseIterGVN& igvn, LoopOptsMode mode) {
if (_loop_opts_cnt > 0) {
debug_only( int cnt = 0; );
while (major_progress() && (_loop_opts_cnt > 0)) {
TracePhase tp("idealLoop", &timers[_t_idealLoop]);
assert( cnt++ < 40, "infinite cycle in loop optimization" );
PhaseIdealLoop::optimize(igvn, mode);
_loop_opts_cnt--;
if (failing()) return false;
Expand Down
125 changes: 125 additions & 0 deletions test/hotspot/jtreg/compiler/loopopts/TestMaxLoopOptsCountReached.java
@@ -0,0 +1,125 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/**
* @test
* @bug 8284944
* @requires vm.compiler2.enabled
* @summary triggers the loop optimization phase `LoopOptsCount` many times
* @run main/othervm -Xcomp -XX:-PartialPeelLoop -XX:CompileCommand=compileonly,TestMaxLoopOptsCountReached::test TestMaxLoopOptsCountReached
*/

import java.lang.System.Logger.Level;

public class TestMaxLoopOptsCountReached {

static Long a = Long.valueOf(42);

class A {

static String e(long f, boolean b, String g, Level h, String s,
Object... i) {
return "message" + s + new String() + g;
}
}

public static void main(String[] args) {
test(null, "", null, null);
test(null, "", null, null);
}

static void test(Integer o, String g, String name, Object obj) {
for (Level q : Level.values())
for (Level r : Level.values())
A.e(a.longValue(), q != Level.OFF, g, null, null);
for (Level q : Level.values())
for (Level r : Level.values())
A.e(a.longValue(), q != Level.OFF, g, null, null);
for (Level q : Level.values()) {
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
}
for (Level q : Level.values()) {
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
}
for (Level q : Level.values()) {
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
for (Level r : Level.values())
;
}
for (Level q : Level.values()) {
for (Level r : Level.values())
;
for (Level r : Level.values())
;
}
for (Level q : Level.values()) {
for (Level r : Level.values()) {
String msg = q + "message";
String val =
(q != Level.OFF || name != msg)
? A.e(a.longValue(), q != Level.OFF, g, null, null, "foo")
: null;
}
for (Level r : Level.values())
;
}
for (Level q : Level.values()) {
for (Level r : Level.values())
;
for (Level r : Level.values())
;
}
}
}

3 comments on commit 796494d

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 796494d Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 796494d Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-796494d0 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 796494d0 from the openjdk/jdk repository.

The commit being backported was authored by Tobias Holenstein on 25 May 2022 and was reviewed by Vladimir Kozlov and Christian Hagedorn.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-796494d0:GoeLin-backport-796494d0
$ git checkout GoeLin-backport-796494d0
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-796494d0

Please sign in to comment.