Skip to content

Commit

Permalink
8296463: Memory leak in JVM_StartThread with the integration of Virtu…
Browse files Browse the repository at this point in the history
…al threads

Reviewed-by: alanb, coleenp, dcubed
  • Loading branch information
David Holmes committed Nov 18, 2022
1 parent 373e52c commit 7b3984c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/hotspot/share/runtime/javaThread.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -599,10 +599,11 @@ JavaThread::JavaThread(ThreadFunction entry_point, size_t stack_sz) : JavaThread

JavaThread::~JavaThread() {

// Ask ServiceThread to release the threadObj OopHandle
// Ask ServiceThread to release the OopHandles
ServiceThread::add_oop_handle_release(_threadObj);
ServiceThread::add_oop_handle_release(_vthread);
ServiceThread::add_oop_handle_release(_jvmti_vthread);
ServiceThread::add_oop_handle_release(_extentLocalCache);

// Return the sleep event to the free list
ParkEvent::Release(_SleepEvent);
Expand Down

3 comments on commit 7b3984c

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dholmes-ora
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk19u

@openjdk
Copy link

@openjdk openjdk bot commented on 7b3984c Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dholmes-ora Could not automatically backport 7b3984cb to openjdk/jdk19u due to conflicts in the following files:

  • src/hotspot/share/runtime/javaThread.cpp

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk19u. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk19u master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b dholmes-ora-backport-7b3984cb

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk 7b3984cb5a08edb99a233c28331c00b25457d664

# Backport the commit
$ git cherry-pick --no-commit 7b3984cb5a08edb99a233c28331c00b25457d664
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 7b3984cb5a08edb99a233c28331c00b25457d664'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk19u with the title Backport 7b3984cb5a08edb99a233c28331c00b25457d664.

Please sign in to comment.