Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
8265173: [test] divert spurious log output away from stream under tes… 
…t in ProcessBuilder Basic test

Reviewed-by: dholmes
  • Loading branch information
Roger Riggs committed Apr 15, 2021
1 parent 4e90d74 commit 7b61a42
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/jdk/java/lang/ProcessBuilder/Basic.java
View file
Expand Up @@ -27,7 +27,7 @@
* 5026830 5023243 5070673 4052517 4811767 6192449 6397034 6413313
* 6464154 6523983 6206031 4960438 6631352 6631966 6850957 6850958
* 4947220 7018606 7034570 4244896 5049299 8003488 8054494 8058464
* 8067796 8224905 8263729
* 8067796 8224905 8263729 8265173
* @key intermittent
* @summary Basic tests for Process and Environment Variable code
* @modules java.base/java.lang:open
Expand Down Expand Up @@ -2150,10 +2150,12 @@ public void doIt(Map<String,String> environ) {
switch (action & 0x1) {
case 0:
childArgs.set(1, "-XX:+DisplayVMOutputToStderr");
childArgs.add(2, "-Xlog:all=warning:stderr");
pb.redirectError(INHERIT);
break;
case 1:
childArgs.set(1, "-XX:+DisplayVMOutputToStdout");
childArgs.add(2, "-Xlog:all=warning:stdout");
pb.redirectOutput(INHERIT);
break;
default:
Expand Down

3 comments on commit 7b61a42

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 7b61a42 Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 7b61a42 Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-7b61a426 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

this pull request contains a backport of commit 7b61a426 from the openjdk/jdk repository.

The commit being backported was authored by Roger Riggs on 15 Apr 2021 and was reviewed by David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-7b61a426:GoeLin-backport-7b61a426
$ git checkout GoeLin-backport-7b61a426
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev GoeLin-backport-7b61a426

Please sign in to comment.