8293647: Avoid unnecessary boxing in jdk.hotspot.agent

Reviewed-by: cjplummer, sspitsyn

Author: Andrey Turbanov

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java

@@ -1226,7 +1226,7 @@ public void doit(Tokens t) {
                 if (t.countTokens() == 0) {
                     out.println("echo is " + doEcho);
                 } else if (t.countTokens() == 1) {
-                    doEcho = Boolean.valueOf(t.nextToken()).booleanValue();
+                    doEcho = Boolean.parseBoolean(t.nextToken());
                 } else {
                     usage();
                 }
@@ -1238,7 +1238,7 @@ public void doit(Tokens t) {
                     out.println("versioncheck is " +
                                 (System.getProperty("sun.jvm.hotspot.runtime.VM.disableVersionCheck") == null));
                 } else if (t.countTokens() == 1) {
-                    if (Boolean.valueOf(t.nextToken()).booleanValue()) {
+                    if (Boolean.parseBoolean(t.nextToken())) {
                         System.clearProperty("sun.jvm.hotspot.runtime.VM.disableVersionCheck");
                     } else {
                         System.setProperty("sun.jvm.hotspot.runtime.VM.disableVersionCheck", "true");
@@ -1302,7 +1302,7 @@ public void doit(Tokens t) {
                     }
                 } else if (t.countTokens() == 2) {
                     String name = t.nextToken();
-                    Integer value = Integer.valueOf(t.nextToken());
+                    int value = Integer.parseInt(t.nextToken());
                     db.addIntConstant(name, value);
                 }
             }
@@ -1325,7 +1325,7 @@ public void doit(Tokens t) {
                     }
                 } else if (t.countTokens() == 2) {
                     String name = t.nextToken();
-                    Long value = Long.valueOf(t.nextToken());
+                    long value = Long.parseLong(t.nextToken());
                     db.addLongConstant(name, value);
                 }
             }
@@ -1352,7 +1352,7 @@ public void doit(Tokens t) {
                     // The field's Type must already be in the database -- no exceptions
                     Type fieldType = agent.getTypeDataBase().lookupType(t.nextToken());
 
-                    boolean isStatic = Boolean.valueOf(t.nextToken()).booleanValue();
+                    boolean isStatic = Boolean.parseBoolean(t.nextToken());
                     long offset = Long.parseLong(t.nextToken());
                     Address staticAddress = parseAddress(t.nextToken());
                     if (isStatic && staticAddress == null) {
@@ -1414,9 +1414,9 @@ public void doit(Tokens t) {
                     if (superclassName.equals("null")) {
                         superclassName = null;
                     }
-                    boolean isOop = Boolean.valueOf(t.nextToken()).booleanValue();
-                    boolean isInteger = Boolean.valueOf(t.nextToken()).booleanValue();
-                    boolean isUnsigned = Boolean.valueOf(t.nextToken()).booleanValue();
+                    boolean isOop = Boolean.parseBoolean(t.nextToken());
+                    boolean isInteger = Boolean.parseBoolean(t.nextToken());
+                    boolean isUnsigned = Boolean.parseBoolean(t.nextToken());
                     long size = Long.parseLong(t.nextToken());
 
                     BasicType type = null;
@@ -1807,7 +1807,7 @@ public void doit(Tokens t) {
                 if (t.countTokens() != 1) {
                     usage();
                 } else {
-                    verboseExceptions = Boolean.valueOf(t.nextToken()).booleanValue();
+                    verboseExceptions = Boolean.parseBoolean(t.nextToken());
                 }
             }
         },
@@ -1816,7 +1816,7 @@ public void doit(Tokens t) {
                 if (t.countTokens() != 1) {
                     usage();
                 } else {
-                    Assert.ASSERTS_ENABLED = Boolean.valueOf(t.nextToken()).booleanValue();
+                    Assert.ASSERTS_ENABLED = Boolean.parseBoolean(t.nextToken());
                 }
             }
         },

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -267,7 +267,7 @@ private void readExternalDefinitions() {
             t.nextToken();
             Type fieldType = lookupType(t.sval);
             t.nextToken();
-            boolean isStatic = Boolean.valueOf(t.sval).booleanValue();
+            boolean isStatic = Boolean.parseBoolean(t.sval);
             t.nextToken();
             long offset = Long.parseLong(t.sval);
             t.nextToken();
@@ -321,11 +321,11 @@ private void readExternalDefinitions() {
               superclassName = null;
             }
             t.nextToken();
-            boolean isOop = Boolean.valueOf(t.sval).booleanValue();
+            boolean isOop = Boolean.parseBoolean(t.sval);
             t.nextToken();
-            boolean isInteger = Boolean.valueOf(t.sval).booleanValue();
+            boolean isInteger = Boolean.parseBoolean(t.sval);
             t.nextToken();
-            boolean isUnsigned = Boolean.valueOf(t.sval).booleanValue();
+            boolean isUnsigned = Boolean.parseBoolean(t.sval);
             t.nextToken();
             long size = Long.parseLong(t.sval);
 

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/PointerFinder.java

@@ -73,7 +73,7 @@ public static PointerLocation find(Address a) {
         JavaThread t = threads.getJavaThreadAt(i);
         Address stackBase = t.getStackBase();
         if (stackBase != null) {
-            Long stackSize = t.getStackSize();
+            long stackSize = t.getStackSize();
             Address stackEnd = stackBase.addOffsetTo(-stackSize);
             if (a.lessThanOrEqual(stackBase) && a.greaterThan(stackEnd)) {
                 loc.stackThread = t;