Skip to content

Commit 7e1d26d

Browse files
committed
8322287: Parallel: Remove unused arg in adjust_eden_for_pause_time and adjust_eden_for_minor_pause_time
Reviewed-by: tschatzl
1 parent 5584ba3 commit 7e1d26d

File tree

2 files changed

+14
-20
lines changed

2 files changed

+14
-20
lines changed

src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -280,11 +280,11 @@ void PSAdaptiveSizePolicy::compute_eden_space_size(
280280
//
281281
// Make changes only to affect one of the pauses (the larger)
282282
// at a time.
283-
adjust_eden_for_pause_time(is_full_gc, &desired_promo_size, &desired_eden_size);
283+
adjust_eden_for_pause_time(&desired_promo_size, &desired_eden_size);
284284

285285
} else if (_avg_minor_pause->padded_average() > gc_minor_pause_goal_sec()) {
286286
// Adjust only for the minor pause time goal
287-
adjust_eden_for_minor_pause_time(is_full_gc, &desired_eden_size);
287+
adjust_eden_for_minor_pause_time(&desired_eden_size);
288288

289289
} else if(adjusted_mutator_cost() < _throughput_goal) {
290290
// This branch used to require that (mutator_cost() > 0.0 in 1.4.2.
@@ -570,9 +570,7 @@ void PSAdaptiveSizePolicy::decay_supplemental_growth(bool is_full_gc) {
570570
}
571571
}
572572

573-
void PSAdaptiveSizePolicy::adjust_eden_for_minor_pause_time(bool is_full_gc,
574-
size_t* desired_eden_size_ptr) {
575-
573+
void PSAdaptiveSizePolicy::adjust_eden_for_minor_pause_time(size_t* desired_eden_size_ptr) {
576574
// Adjust the young generation size to reduce pause time of
577575
// of collections.
578576
//
@@ -585,12 +583,12 @@ void PSAdaptiveSizePolicy::adjust_eden_for_minor_pause_time(bool is_full_gc,
585583
decrease_young_gen_for_min_pauses_true);
586584
*desired_eden_size_ptr = *desired_eden_size_ptr -
587585
eden_decrement_aligned_down(*desired_eden_size_ptr);
588-
} else {
589-
// EXPERIMENTAL ADJUSTMENT
590-
// Only record that the estimator indicated such an action.
591-
// *desired_eden_size_ptr = *desired_eden_size_ptr + eden_heap_delta;
592-
set_change_young_gen_for_min_pauses(
593-
increase_young_gen_for_min_pauses_true);
586+
} else {
587+
// EXPERIMENTAL ADJUSTMENT
588+
// Only record that the estimator indicated such an action.
589+
// *desired_eden_size_ptr = *desired_eden_size_ptr + eden_heap_delta;
590+
set_change_young_gen_for_min_pauses(
591+
increase_young_gen_for_min_pauses_true);
594592
}
595593
}
596594

@@ -630,16 +628,15 @@ void PSAdaptiveSizePolicy::adjust_promo_for_pause_time(bool is_full_gc,
630628
*desired_promo_size_ptr, promo_heap_delta);
631629
}
632630

633-
void PSAdaptiveSizePolicy::adjust_eden_for_pause_time(bool is_full_gc,
634-
size_t* desired_promo_size_ptr,
635-
size_t* desired_eden_size_ptr) {
631+
void PSAdaptiveSizePolicy::adjust_eden_for_pause_time(size_t* desired_promo_size_ptr,
632+
size_t* desired_eden_size_ptr) {
636633

637634
size_t eden_heap_delta = 0;
638635
// Add some checks for a threshold for a change. For example,
639636
// a change less than the required alignment is probably not worth
640637
// attempting.
641638
if (_avg_minor_pause->padded_average() > _avg_major_pause->padded_average()) {
642-
adjust_eden_for_minor_pause_time(is_full_gc, desired_eden_size_ptr);
639+
adjust_eden_for_minor_pause_time(desired_eden_size_ptr);
643640
}
644641
log_trace(gc, ergo)(
645642
"PSAdaptiveSizePolicy::adjust_eden_for_pause_time "

src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.hpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,16 +116,13 @@ class PSAdaptiveSizePolicy : public AdaptiveSizePolicy {
116116
// Accessors
117117
double gc_minor_pause_goal_sec() const { return _gc_minor_pause_goal_sec; }
118118

119-
void adjust_eden_for_minor_pause_time(bool is_full_gc,
120-
size_t* desired_eden_size_ptr);
119+
void adjust_eden_for_minor_pause_time(size_t* desired_eden_size_ptr);
121120
// Change the generation sizes to achieve a GC pause time goal
122121
// Returned sizes are not necessarily aligned.
123122
void adjust_promo_for_pause_time(bool is_full_gc,
124123
size_t* desired_promo_size_ptr,
125124
size_t* desired_eden_size_ptr);
126-
void adjust_eden_for_pause_time(bool is_full_gc,
127-
size_t* desired_promo_size_ptr,
128-
size_t* desired_eden_size_ptr);
125+
void adjust_eden_for_pause_time(size_t* desired_promo_size_ptr, size_t* desired_eden_size_ptr);
129126
// Change the generation sizes to achieve an application throughput goal
130127
// Returned sizes are not necessarily aligned.
131128
void adjust_promo_for_throughput(bool is_full_gc,

0 commit comments

Comments
 (0)