Skip to content

Commit

Permalink
8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm
Browse files Browse the repository at this point in the history
Reviewed-by: mli, tschatzl
  • Loading branch information
lkorinth committed Oct 17, 2023
1 parent 75b37e6 commit 7e39e66
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -25,7 +25,7 @@

/*
* @test TestG1ConcMarkStepDurationMillis
* @requires vm.gc.G1
* @requires vm.gc.G1 & vm.opt.G1ConcMarkStepDurationMillis == null
* @summary Tests argument processing for double type flag, G1ConcMarkStepDurationMillis
* @library /test/lib
* @library /
Expand Down Expand Up @@ -78,7 +78,7 @@ private static void runG1ConcMarkStepDurationMillisTest(String expectedValue, in

Collections.addAll(vmOpts, "-XX:+UseG1GC", "-XX:G1ConcMarkStepDurationMillis="+expectedValue, "-XX:+PrintFlagsFinal", "-version");

ProcessBuilder pb = GCArguments.createJavaProcessBuilder(vmOpts);
ProcessBuilder pb = GCArguments.createTestJvm(vmOpts);
OutputAnalyzer output = new OutputAnalyzer(pb.start());

output.shouldHaveExitValue(expectedResult == PASS ? 0 : 1);
Expand Down

3 comments on commit 7e39e66

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 7e39e66 Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 7e39e66 Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch backport-GoeLin-7e39e664 in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 7e39e664 from the openjdk/jdk repository.

The commit being backported was authored by Leo Korinth on 17 Oct 2023 and was reviewed by Hamlin Li and Thomas Schatzl.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-7e39e664:backport-GoeLin-7e39e664
$ git checkout backport-GoeLin-7e39e664
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-7e39e664

Please sign in to comment.