Permalink
Show file tree
Hide file tree
1 comment
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
8223923: C2: Missing interference with mismatched unsafe accesses
Reviewed-by: thartmann
- Loading branch information
Vladimir Ivanov
committed
Aug 20, 2021
1 parent
c701f6e
commit 86add21a85ec57de00aecb0a18bc99567a91d0d8
Showing
2 changed files
with
82 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
/* | ||
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
/* | ||
* @test | ||
* @bug 8223923 | ||
* @modules java.base/jdk.internal.misc | ||
* @run main/othervm -Xbatch compiler.unsafe.MismatchedUnsafeAccessTest | ||
*/ | ||
package compiler.unsafe; | ||
|
||
import jdk.internal.misc.Unsafe; | ||
|
||
public class MismatchedUnsafeAccessTest { | ||
private static final Unsafe UNSAFE = Unsafe.getUnsafe(); | ||
|
||
public static class Test { | ||
public int x = 0; | ||
public int y = 0; | ||
|
||
public static final long offsetX; | ||
public static final long offsetY; | ||
|
||
static { | ||
try { | ||
offsetX = UNSAFE.objectFieldOffset(Test.class.getField("x")); | ||
offsetY = UNSAFE.objectFieldOffset(Test.class.getField("y")); | ||
} catch (NoSuchFieldException e) { | ||
throw new InternalError(e); | ||
} | ||
// Validate offsets | ||
if (offsetX >= offsetY || offsetY - offsetX != 4) { | ||
throw new InternalError("Wrong offsets: " + offsetX + " " + offsetY); | ||
} | ||
} | ||
} | ||
|
||
public static int test(long l) { | ||
Test a = new Test(); | ||
UNSAFE.putLong(a, Test.offsetX, l); // mismatched access; interferes with subsequent load | ||
return UNSAFE.getInt(a, Test.offsetY); | ||
} | ||
|
||
public static void main(String[] args) { | ||
for (int i = 0; i < 20_000; i++) { | ||
int res = test(-1L); | ||
if (res != -1) { | ||
throw new AssertionError("Wrong result: " + res); | ||
} | ||
} | ||
System.out.println("TEST PASSED"); | ||
} | ||
} |
86add21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues