Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
8257574: C2: "failed: parsing found no loops but there are some" asse…
…rt failure

Reviewed-by: thartmann, neliasso, chagedorn
  • Loading branch information
rwestrel committed Dec 4, 2020
1 parent dede01e commit 86b6575
Show file tree
Hide file tree
Showing 2 changed files with 60 additions and 16 deletions.
30 changes: 14 additions & 16 deletions src/hotspot/share/opto/loopnode.cpp
Expand Up @@ -3663,25 +3663,23 @@ bool PhaseIdealLoop::process_expensive_nodes() {

#ifdef ASSERT
bool PhaseIdealLoop::only_has_infinite_loops() {
for (LoopTreeIterator iter(_ltree_root); !iter.done(); iter.next()) {
IdealLoopTree* lpt = iter.current();
if (lpt->is_innermost()) {
uint i = 1;
for (; i < C->root()->req(); i++) {
Node* in = C->root()->in(i);
if (in != NULL &&
in->Opcode() == Op_Halt &&
in->in(0)->is_Proj() &&
in->in(0)->in(0)->Opcode() == Op_NeverBranch &&
in->in(0)->in(0)->in(0) == lpt->_head) {
break;
}
}
if (i == C->root()->req()) {
return false;
for (IdealLoopTree* l = _ltree_root->_child; l != NULL; l = l->_next) {
uint i = 1;
for (; i < C->root()->req(); i++) {
Node* in = C->root()->in(i);
if (in != NULL &&
in->Opcode() == Op_Halt &&
in->in(0)->is_Proj() &&
in->in(0)->in(0)->Opcode() == Op_NeverBranch &&
in->in(0)->in(0)->in(0) == l->_head) {
break;
}
}
if (i == C->root()->req()) {
return false;
}
}

return true;
}
#endif
Expand Down
@@ -0,0 +1,46 @@
/*
* Copyright (c) 2020, Red Hat, Inc. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/**
* @test
* @bug 8257574
* @summary C2: "failed: parsing found no loops but there are some" assert failure
*
* @run main/othervm -Xcomp -XX:CompileOnly=TestInfiniteLoopNotInnerMost::test TestInfiniteLoopNotInnerMost
*
*/
public class TestInfiniteLoopNotInnerMost {
public static void main(String[] args) {
test(false);
}

private static void test(boolean flag) {
if (flag) {
while (true) {
for (int i = 1; i < 100; i *= 2) {

}
}
}
}
}

1 comment on commit 86b6575

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.