Skip to content

Commit 8752257

Browse files
committed
8260502: [s390] NativeMovRegMem::verify() fails because it's too strict
Reviewed-by: lucy, rrich
1 parent 8fe1323 commit 8752257

File tree

2 files changed

+1
-28
lines changed

2 files changed

+1
-28
lines changed

src/hotspot/cpu/s390/nativeInst_s390.cpp

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,6 @@ void NativeMovConstReg::set_pcrel_data(intptr_t newData, CompiledMethod *passed_
601601

602602
void NativeMovRegMem::verify() {
603603
address l1 = addr_at(0);
604-
address l2 = addr_at(MacroAssembler::load_const_size());
605604

606605
if (!MacroAssembler::is_load_const(l1)) {
607606
tty->cr();
@@ -610,32 +609,6 @@ void NativeMovRegMem::verify() {
610609
((NativeMovRegMem*)l1)->dump(64, "NativeMovConstReg::verify()");
611610
fatal("this is not a `NativeMovRegMem' site");
612611
}
613-
614-
unsigned long inst1;
615-
Assembler::get_instruction(l2, &inst1);
616-
617-
if (!Assembler::is_z_lb(inst1) &&
618-
!Assembler::is_z_llgh(inst1) &&
619-
!Assembler::is_z_lh(inst1) &&
620-
!Assembler::is_z_l(inst1) &&
621-
!Assembler::is_z_llgf(inst1) &&
622-
!Assembler::is_z_lg(inst1) &&
623-
!Assembler::is_z_le(inst1) &&
624-
!Assembler::is_z_ld(inst1) &&
625-
!Assembler::is_z_stc(inst1) &&
626-
!Assembler::is_z_sth(inst1) &&
627-
!Assembler::is_z_st(inst1) &&
628-
!UseCompressedOops &&
629-
!Assembler::is_z_stg(inst1) &&
630-
!Assembler::is_z_ste(inst1) &&
631-
!Assembler::is_z_std(inst1)) {
632-
tty->cr();
633-
tty->print_cr("NativeMovRegMem::verify(): verifying addr " PTR_FORMAT
634-
": wrong or missing load or store at " PTR_FORMAT, p2i(l1), p2i(l2));
635-
tty->cr();
636-
((NativeMovRegMem*)l1)->dump(64, "NativeMovConstReg::verify()");
637-
fatal("this is not a `NativeMovRegMem' site");
638-
}
639612
}
640613
#endif // COMPILER1
641614

src/hotspot/cpu/s390/nativeInst_s390.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ class NativeMovConstReg: public NativeInstruction {
516516
// The instruction sequence looks like this:
517517
// iihf %r1,$bits1 ; load offset for mem access
518518
// iilf %r1,$bits2
519-
// [compress oop] ; optional, load only
519+
// [compress oop] ; optional, store only
520520
// load/store %r2,0(%r1,%r2) ; memory access
521521

522522
class NativeMovRegMem;

0 commit comments

Comments
 (0)