Skip to content

Commit 8ea2a67

Browse files
author
Sangheon Kim
committed
8292265: Add old gen used field at G1HeapSummary JFR event
Reviewed-by: tschatzl, ayang
1 parent 478ef38 commit 8ea2a67

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

src/hotspot/share/gc/g1/g1CollectedHeap.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2558,16 +2558,17 @@ bool G1CollectedHeap::print_location(outputStream* st, void* addr) const {
25582558

25592559
G1HeapSummary G1CollectedHeap::create_g1_heap_summary() {
25602560

2561-
size_t eden_used_bytes = _eden.used_bytes();
2562-
size_t survivor_used_bytes = _survivor.used_bytes();
2561+
size_t eden_used_bytes = _monitoring_support->eden_space_used();
2562+
size_t survivor_used_bytes = _monitoring_support->survivor_space_used();
2563+
size_t old_gen_used_bytes = _monitoring_support->old_gen_used();
25632564
size_t heap_used = Heap_lock->owned_by_self() ? used() : used_unlocked();
25642565

25652566
size_t eden_capacity_bytes =
25662567
(policy()->young_list_target_length() * HeapRegion::GrainBytes) - survivor_used_bytes;
25672568

25682569
VirtualSpaceSummary heap_summary = create_heap_space_summary();
2569-
return G1HeapSummary(heap_summary, heap_used, eden_used_bytes,
2570-
eden_capacity_bytes, survivor_used_bytes, num_regions());
2570+
return G1HeapSummary(heap_summary, heap_used, eden_used_bytes, eden_capacity_bytes,
2571+
survivor_used_bytes, old_gen_used_bytes, num_regions());
25712572
}
25722573

25732574
G1EvacSummary G1CollectedHeap::create_g1_evac_summary(G1EvacStats* stats) {

src/hotspot/share/gc/shared/gcHeapSummary.hpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2012, 2019, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2012, 2022, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -117,13 +117,15 @@ class G1HeapSummary : public GCHeapSummary {
117117
size_t _edenUsed;
118118
size_t _edenCapacity;
119119
size_t _survivorUsed;
120+
size_t _oldGenUsed;
120121
uint _numberOfRegions;
121122
public:
122-
G1HeapSummary(VirtualSpaceSummary& heap_space, size_t heap_used, size_t edenUsed, size_t edenCapacity, size_t survivorUsed, uint numberOfRegions) :
123-
GCHeapSummary(heap_space, heap_used), _edenUsed(edenUsed), _edenCapacity(edenCapacity), _survivorUsed(survivorUsed), _numberOfRegions(numberOfRegions) { }
123+
G1HeapSummary(VirtualSpaceSummary& heap_space, size_t heap_used, size_t edenUsed, size_t edenCapacity, size_t survivorUsed, size_t oldGenUsed, uint numberOfRegions) :
124+
GCHeapSummary(heap_space, heap_used), _edenUsed(edenUsed), _edenCapacity(edenCapacity), _survivorUsed(survivorUsed), _oldGenUsed(oldGenUsed), _numberOfRegions(numberOfRegions) { }
124125
const size_t edenUsed() const { return _edenUsed; }
125126
const size_t edenCapacity() const { return _edenCapacity; }
126127
const size_t survivorUsed() const { return _survivorUsed; }
128+
const size_t oldGenUsed() const { return _oldGenUsed; }
127129
const uint numberOfRegions() const { return _numberOfRegions; }
128130

129131
virtual void accept(GCHeapSummaryVisitor* visitor) const {

src/hotspot/share/gc/shared/gcTraceSend.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ class GCHeapSummaryEventSender : public GCHeapSummaryVisitor {
244244
e.set_edenUsedSize(g1_heap_summary->edenUsed());
245245
e.set_edenTotalSize(g1_heap_summary->edenCapacity());
246246
e.set_survivorUsedSize(g1_heap_summary->survivorUsed());
247+
e.set_oldGenUsedSize(g1_heap_summary->oldGenUsed());
247248
e.set_numberOfRegions(g1_heap_summary->numberOfRegions());
248249
e.commit();
249250
}

src/hotspot/share/jfr/metadata/metadata.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,7 @@
329329
<Field type="ulong" contentType="bytes" name="edenUsedSize" label="Eden Used Size" />
330330
<Field type="ulong" contentType="bytes" name="edenTotalSize" label="Eden Total Size" />
331331
<Field type="ulong" contentType="bytes" name="survivorUsedSize" label="Survivor Used Size" />
332+
<Field type="ulong" contentType="bytes" name="oldGenUsedSize" label="Old Generation Used Size" />
332333
<Field type="uint" name="numberOfRegions" label="Number of Regions" />
333334
</Event>
334335

0 commit comments

Comments
 (0)