Skip to content

Commit

Permalink
8313798: [aarch64] sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java…
Browse files Browse the repository at this point in the history
… sometimes times out on aarch64

Reviewed-by: kevinw, sspitsyn
  • Loading branch information
plummercj committed Aug 11, 2023
1 parent 1232677 commit 8f1c134
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2000, 2017, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2000, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -27,6 +27,7 @@
import java.io.*;
import sun.jvm.hotspot.code.*;
import sun.jvm.hotspot.utilities.*;
import sun.jvm.hotspot.debugger.Address;

public class VFrame {
protected Frame fr;
Expand Down Expand Up @@ -145,7 +146,16 @@ public JavaVFrame javaSender() {
if (f.isJavaFrame()) {
return (JavaVFrame) f;
}
Address oldSP = f.getFrame().getSP();
f = f.sender(imprecise);
if (f != null) {
// Make sure the sender frame is above the current frame, not below
Address newSP = f.getFrame().getSP();
if (oldSP.greaterThanOrEqual(newSP)) {
String errString = "newSP(" + newSP + ") is not above oldSP(" + oldSP + ")";
throw new RuntimeException(errString);
}
}
}
return null;
}
Expand Down
1 change: 0 additions & 1 deletion test/jdk/ProblemList.txt
Expand Up @@ -734,7 +734,6 @@ sun/tools/jstat/jstatLineCounts3.sh 8268211 linux-aa
sun/tools/jstat/jstatLineCounts4.sh 8268211 linux-aarch64

sun/tools/jhsdb/JStackStressTest.java 8276210 linux-aarch64
sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java 8313798 generic-aarch64

############################################################################

Expand Down

1 comment on commit 8f1c134

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.