From 915084041f32bf6ffe4d12c031ac5e69adcc07f5 Mon Sep 17 00:00:00 2001 From: Albert Mingkun Yang Date: Tue, 30 Nov 2021 13:42:18 +0000 Subject: [PATCH] 8277899: Parallel: Simplify PSVirtualSpace::initialize logic Reviewed-by: tschatzl, sjohanss --- src/hotspot/share/gc/parallel/objectStartArray.cpp | 4 +--- src/hotspot/share/gc/parallel/psVirtualspace.cpp | 8 +------- src/hotspot/share/gc/parallel/psVirtualspace.hpp | 2 +- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/hotspot/share/gc/parallel/objectStartArray.cpp b/src/hotspot/share/gc/parallel/objectStartArray.cpp index e75a1efa73437..c9c7ac6b796df 100644 --- a/src/hotspot/share/gc/parallel/objectStartArray.cpp +++ b/src/hotspot/share/gc/parallel/objectStartArray.cpp @@ -65,9 +65,7 @@ void ObjectStartArray::initialize(MemRegion reserved_region) { MemTracker::record_virtual_memory_type((address)backing_store.base(), mtGC); // We do not commit any memory initially - if (!_virtual_space.initialize(backing_store, 0)) { - vm_exit_during_initialization("Could not commit space for ObjectStartArray"); - } + _virtual_space.initialize(backing_store); _raw_base = (jbyte*)_virtual_space.low_boundary(); diff --git a/src/hotspot/share/gc/parallel/psVirtualspace.cpp b/src/hotspot/share/gc/parallel/psVirtualspace.cpp index d0bf10c32dac9..830aa54d2b1d8 100644 --- a/src/hotspot/share/gc/parallel/psVirtualspace.cpp +++ b/src/hotspot/share/gc/parallel/psVirtualspace.cpp @@ -56,16 +56,10 @@ PSVirtualSpace::PSVirtualSpace(): } // Deprecated. -bool PSVirtualSpace::initialize(ReservedSpace rs, - size_t commit_size) { +void PSVirtualSpace::initialize(ReservedSpace rs) { set_reserved(rs); set_committed(reserved_low_addr(), reserved_low_addr()); - - // Commit to initial size. - assert(commit_size <= rs.size(), "commit_size too big"); - bool result = commit_size > 0 ? expand_by(commit_size) : true; DEBUG_ONLY(verify()); - return result; } PSVirtualSpace::~PSVirtualSpace() { diff --git a/src/hotspot/share/gc/parallel/psVirtualspace.hpp b/src/hotspot/share/gc/parallel/psVirtualspace.hpp index 1c3721ce0192b..4bb0547e3f11f 100644 --- a/src/hotspot/share/gc/parallel/psVirtualspace.hpp +++ b/src/hotspot/share/gc/parallel/psVirtualspace.hpp @@ -73,7 +73,7 @@ class PSVirtualSpace : public CHeapObj { _special(false) { } PSVirtualSpace(); - bool initialize(ReservedSpace rs, size_t commit_size); + void initialize(ReservedSpace rs); bool contains(void* p) const;