Skip to content

Commit

Permalink
8297333: Parallel: Remove unused methods in PCIterateMarkAndPushClosure
Browse files Browse the repository at this point in the history
Reviewed-by: tschatzl, sjohanss
  • Loading branch information
albertnetymk committed Nov 22, 2022
1 parent 42c2037 commit 932bf35
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
4 changes: 0 additions & 4 deletions src/hotspot/share/gc/parallel/psCompactionManager.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,6 @@ class ParCompactionManager : public CHeapObj<mtGC> {
// Check mark and maybe push on marking stack.
template <typename T> inline void mark_and_push(T* p);

inline void follow_klass(Klass* klass);

void follow_class_loader(ClassLoaderData* klass);

// Access function for compaction managers
static ParCompactionManager* gc_thread_compaction_manager(uint index);

Expand Down
13 changes: 0 additions & 13 deletions src/hotspot/share/gc/parallel/psCompactionManager.inline.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ class PCIterateMarkAndPushClosure: public MetadataVisitingOopIterateClosure {
template <typename T> void do_oop_nv(T* p) { _compaction_manager->mark_and_push(p); }
virtual void do_oop(oop* p) { do_oop_nv(p); }
virtual void do_oop(narrowOop* p) { do_oop_nv(p); }

void do_klass_nv(Klass* k) { _compaction_manager->follow_klass(k); }
void do_cld_nv(ClassLoaderData* cld) { _compaction_manager->follow_class_loader(cld); }
};

inline bool ParCompactionManager::steal(int queue_num, oop& t) {
Expand Down Expand Up @@ -119,11 +116,6 @@ inline void ParCompactionManager::mark_and_push(T* p) {
}
}

inline void ParCompactionManager::follow_klass(Klass* klass) {
oop holder = klass->class_loader_data()->holder_no_keepalive();
mark_and_push(&holder);
}

inline void ParCompactionManager::FollowStackClosure::do_void() {
_compaction_manager->follow_marking_stacks();
if (_terminator != nullptr) {
Expand Down Expand Up @@ -168,11 +160,6 @@ inline void ParCompactionManager::update_contents(oop obj) {
}
}

inline void ParCompactionManager::follow_class_loader(ClassLoaderData* cld) {
PCMarkAndPushClosure mark_and_push_closure(this);
cld->oops_do(&mark_and_push_closure, true);
}

inline void ParCompactionManager::follow_contents(oop obj) {
assert(PSParallelCompact::mark_bitmap()->is_marked(obj), "should be marked");
if (obj->is_objArray()) {
Expand Down

1 comment on commit 932bf35

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.