Skip to content

Commit

Permalink
8328589: unify os::breakpoint among posix platforms
Browse files Browse the repository at this point in the history 
Reviewed-by: lucy, asteiner, dholmes
  • Loading branch information
@MBaesken
MBaesken committed Mar 21, 2024
1 parent a5a2eca commit 93d1700
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 33 deletions.
11 changes: 0 additions & 11 deletions src/hotspot/os/aix/os_aix.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -621,17 +621,6 @@ void os::init_system_properties_values() {
#undef EXTENSIONS_DIR
}

////////////////////////////////////////////////////////////////////////////////
// breakpoint support

void os::breakpoint() {
BREAKPOINT;
}

extern "C" void breakpoint() {
// use debugger to set breakpoint here
}

// retrieve memory information.
// Returns false if something went wrong;
// content of pmi undefined in this case.
Expand Down
11 changes: 0 additions & 11 deletions src/hotspot/os/bsd/os_bsd.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -535,17 +535,6 @@ void os::init_system_properties_values() {
#undef EXTENSIONS_DIR
}

////////////////////////////////////////////////////////////////////////////////
// breakpoint support

void os::breakpoint() {
BREAKPOINT;
}

extern "C" void breakpoint() {
// use debugger to set breakpoint here
}

//////////////////////////////////////////////////////////////////////////////
// create new thread

Expand Down
11 changes: 0 additions & 11 deletions src/hotspot/os/linux/os_linux.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -640,17 +640,6 @@ void os::init_system_properties_values() {
#undef EXTENSIONS_DIR
}

////////////////////////////////////////////////////////////////////////////////
// breakpoint support

void os::breakpoint() {
BREAKPOINT;
}

extern "C" void breakpoint() {
// use debugger to set breakpoint here
}

//////////////////////////////////////////////////////////////////////////////
// detecting pthread library

Expand Down
11 changes: 11 additions & 0 deletions src/hotspot/os/posix/os_posix.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,17 @@ size_t os::lasterror(char *buf, size_t len) {
return n;
}

////////////////////////////////////////////////////////////////////////////////
// breakpoint support

void os::breakpoint() {
BREAKPOINT;
}

extern "C" void breakpoint() {
// use debugger to set breakpoint here
}

// Return true if user is running as root.
bool os::have_special_privileges() {
static bool privileges = (getuid() != geteuid()) || (getgid() != getegid());
Expand Down

5 comments on commit 93d1700

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 93d1700 Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch backport-MBaesken-93d1700f in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 93d1700f from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 21 Mar 2024 and was reviewed by Lutz Schmidt, Andreas Steiner and David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-MBaesken-93d1700f:backport-MBaesken-93d1700f
$ git checkout backport-MBaesken-93d1700f
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-MBaesken-93d1700f

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk22u

@openjdk
Copy link

@openjdk openjdk bot commented on 93d1700 Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch backport-MBaesken-93d1700f in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 93d1700f from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 21 Mar 2024 and was reviewed by Lutz Schmidt, Andreas Steiner and David Holmes.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-MBaesken-93d1700f:backport-MBaesken-93d1700f
$ git checkout backport-MBaesken-93d1700f
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-MBaesken-93d1700f

Please sign in to comment.