Skip to content

Commit

Permalink
8339560: Unaddressed comments during code review of JDK-8337664
Browse files Browse the repository at this point in the history 
Reviewed-by: mullan
  • Loading branch information
@fguallini @seanjmullan
fguallini authored and seanjmullan committed Sep 26, 2024
1 parent 47fcf5a commit 95d3e9d
Show file tree
Hide file tree
Showing 25 changed files with 243 additions and 393 deletions.
292 changes: 0 additions & 292 deletions test/jdk/sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java
View file

This file was deleted.

Loading

3 comments on commit 95d3e9d

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on 95d3e9d Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 95d3e9d Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch backport-GoeLin-95d3e9d1-master in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 95d3e9d1 from the openjdk/jdk repository.

The commit being backported was authored by Fernando Guallini on 26 Sep 2024 and was reviewed by Sean Mullan.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-95d3e9d1-master:backport-GoeLin-95d3e9d1-master
$ git checkout backport-GoeLin-95d3e9d1-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-GoeLin-95d3e9d1-master

Please sign in to comment.