Skip to content

Commit 9a49418

Browse files
artur-oraclewangweij
authored andcommitted
8345940: Migrate security-related resources from Java classes to properties files
Reviewed-by: jlu, weijun, erikj
1 parent e71f327 commit 9a49418

File tree

83 files changed

+6092
-10137
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

83 files changed

+6092
-10137
lines changed

make/modules/java.base/Gensrc.gmk

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,16 +80,17 @@ $(eval $(call SetupCompileProperties, SUN_UTIL, \
8080
CLASS := sun.util.resources.LocaleNamesBundle, \
8181
))
8282

83-
TARGETS += $(LIST_RESOURCE_BUNDLE) $(SUN_UTIL)
83+
$(eval $(call SetupCompileProperties, SECURITY_RESOURCES, \
84+
SRC_DIRS := $(MODULE_SRC)/share/classes/sun/security/util/resources, \
85+
CLASS := ListResourceBundle, \
86+
))
8487

85-
# Some resources bundles are already present as java files but still need to be
86-
# copied to zh_HK locale.
87-
$(eval $(call SetupCopy-zh_HK,COPY_ZH_HK, \
88-
$(addprefix $(TOPDIR)/src/java.base/share/classes/, \
89-
sun/security/util/AuthResources_zh_TW.java \
90-
sun/security/util/Resources_zh_TW.java)))
88+
$(eval $(call SetupCompileProperties, KEYTOOL_RESOURCES, \
89+
SRC_DIRS := $(MODULE_SRC)/share/classes/sun/security/tools/keytool/resources, \
90+
CLASS := ListResourceBundle, \
91+
))
9192

92-
TARGETS += $(COPY_ZH_HK)
93+
TARGETS += $(LIST_RESOURCE_BUNDLE) $(SUN_UTIL) $(SECURITY_RESOURCES) $(KEYTOOL_RESOURCES)
9394

9495
################################################################################
9596

make/modules/jdk.jartool/Gensrc.gmk

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ $(eval $(call SetupCompileProperties, COMPILE_PROPERTIES, \
3333
CLASS := ListResourceBundle, \
3434
))
3535

36-
TARGETS += $(COMPILE_PROPERTIES)
36+
$(eval $(call SetupCompileProperties, JARSIGNER_RESOURCES, \
37+
SRC_DIRS := $(TOPDIR)/src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources, \
38+
CLASS := ListResourceBundle, \
39+
))
40+
41+
TARGETS += $(COMPILE_PROPERTIES) $(JARSIGNER_RESOURCES)
3742

3843
################################################################################

src/java.base/share/classes/sun/security/tools/keytool/Main.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ public String toString() {
388388
// for i18n
389389
private static final java.util.ResourceBundle rb =
390390
java.util.ResourceBundle.getBundle(
391-
"sun.security.tools.keytool.Resources");
391+
"sun.security.tools.keytool.resources.keytool");
392392
private static final Collator collator = Collator.getInstance();
393393
static {
394394
// this is for case-insensitive string comparisons
@@ -2069,7 +2069,7 @@ private void doGenKeyPair(String alias, String dname, String keyAlgName,
20692069
* - plain algorithm name, otherwise
20702070
*
20712071
* Note: the same method appears in keytool and jarsigner which uses
2072-
* same resource string defined in their own Resources.java.
2072+
* same resource string defined in their own properties file.
20732073
*
20742074
* @param key the key object, cannot be null
20752075
* @return the full name

src/java.base/share/classes/sun/security/tools/keytool/Resources.java

Lines changed: 0 additions & 519 deletions
This file was deleted.

src/java.base/share/classes/sun/security/tools/keytool/Resources_de.java

Lines changed: 0 additions & 511 deletions
This file was deleted.

src/java.base/share/classes/sun/security/tools/keytool/Resources_es.java

Lines changed: 0 additions & 484 deletions
This file was deleted.

src/java.base/share/classes/sun/security/tools/keytool/Resources_fr.java

Lines changed: 0 additions & 484 deletions
This file was deleted.

src/java.base/share/classes/sun/security/tools/keytool/Resources_it.java

Lines changed: 0 additions & 484 deletions
This file was deleted.

src/java.base/share/classes/sun/security/tools/keytool/Resources_ja.java

Lines changed: 0 additions & 511 deletions
This file was deleted.

src/java.base/share/classes/sun/security/tools/keytool/Resources_ko.java

Lines changed: 0 additions & 484 deletions
This file was deleted.

0 commit comments

Comments
 (0)