8318646: Integer#parseInt("") throws empty NumberFormatException message

Reviewed-by: redestad, alanb, bpb, darcy, uschindler
openjdk · Oct 24, 2023 · 9bfa082 · 9bfa082 · openjdk-notifier · Oct 24, 2023
1 parent 3f446c5
commit 9bfa082
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/java.base/share/classes/java/lang/Integer.java b/src/java.base/share/classes/java/lang/Integer.java
@@ -562,7 +562,7 @@ public static int parseInt(String s, int radix)
 
         int len = s.length();
         if (len == 0) {
-            throw new NumberFormatException("");
+            throw NumberFormatException.forInputString("", radix);
         }
         int digit = ~0xFF;
         int i = 0;
@@ -637,7 +637,7 @@ public static int parseInt(CharSequence s, int beginIndex, int endIndex, int rad
          * and by not updating i anywhere else.
          */
         if (beginIndex == endIndex) {
-            throw new NumberFormatException("");
+            throw NumberFormatException.forInputString("", radix);
         }
         int digit = ~0xFF;
         int i = beginIndex;
@@ -827,7 +827,7 @@ public static int parseUnsignedInt(CharSequence s, int beginIndex, int endIndex,
          * and by not updating i anywhere else.
          */
         if (beginIndex == endIndex) {
-            throw new NumberFormatException("");
+            throw NumberFormatException.forInputString("", radix);
         }
         int i = beginIndex;
         char firstChar = s.charAt(i++);

diff --git a/src/java.base/share/classes/java/lang/Long.java b/src/java.base/share/classes/java/lang/Long.java
@@ -592,7 +592,7 @@ public static long parseLong(String s, int radix)
 
         int len = s.length();
         if (len == 0) {
-            throw new NumberFormatException("");
+            throw NumberFormatException.forInputString("", radix);
         }
         int digit = ~0xFF;
         int i = 0;
@@ -667,7 +667,7 @@ public static long parseLong(CharSequence s, int beginIndex, int endIndex, int r
          * and by not updating i anywhere else.
          */
         if (beginIndex == endIndex) {
-            throw new NumberFormatException("");
+            throw NumberFormatException.forInputString("", radix);
         }
         int digit = ~0xFF;  // ~0xFF means firstChar char is sign
         int i = beginIndex;
@@ -864,7 +864,7 @@ public static long parseUnsignedLong(CharSequence s, int beginIndex, int endInde
          * and by not updating i anywhere else.
          */
         if (beginIndex == endIndex) {
-            throw new NumberFormatException("");
+            throw NumberFormatException.forInputString("", radix);
         }
         int i = beginIndex;
         char firstChar = s.charAt(i++);