Skip to content

Commit

Permalink
8325862: set -XX:+ErrorFileToStderr when executing java in containers…
Browse files Browse the repository at this point in the history 
… for some container related jtreg tests

Reviewed-by: sgehwolf, stuefe, mdoerr
  • Loading branch information
@MBaesken
MBaesken committed Feb 16, 2024
1 parent 0aaec97 commit 9f4ec21
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/lib/jdk/test/lib/containers/docker/DockerRunOptions.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2017, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -60,6 +60,9 @@ public DockerRunOptions(String imageNameAndTag, String javaCmd,
this.command = javaCmd;
this.classToRun = classToRun;
this.addJavaOpts(javaOpts);
// always print hserr to stderr in the docker tests to avoid
// trouble accessing it after a crash in the container
this.addJavaOpts("-XX:+ErrorFileToStderr");
}

public DockerRunOptions addDockerOpts(String... opts) {
Expand Down

9 comments on commit 9f4ec21

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk22u

@openjdk
Copy link

@openjdk openjdk bot commented on 9f4ec21 Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch backport-MBaesken-9f4ec21f in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 9f4ec21f from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 16 Feb 2024 and was reviewed by Severin Gehwolf, Thomas Stuefe and Martin Doerr.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-MBaesken-9f4ec21f:backport-MBaesken-9f4ec21f
$ git checkout backport-MBaesken-9f4ec21f
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-MBaesken-9f4ec21f

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk21u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 9f4ec21 Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch backport-MBaesken-9f4ec21f in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 9f4ec21f from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 16 Feb 2024 and was reviewed by Severin Gehwolf, Thomas Stuefe and Martin Doerr.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-MBaesken-9f4ec21f:backport-MBaesken-9f4ec21f
$ git checkout backport-MBaesken-9f4ec21f
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-MBaesken-9f4ec21f

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 9f4ec21 Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch backport-MBaesken-9f4ec21f in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 9f4ec21f from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 16 Feb 2024 and was reviewed by Severin Gehwolf, Thomas Stuefe and Martin Doerr.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-MBaesken-9f4ec21f:backport-MBaesken-9f4ec21f
$ git checkout backport-MBaesken-9f4ec21f
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-MBaesken-9f4ec21f

@MBaesken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on 9f4ec21 Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBaesken the backport was successfully created on the branch backport-MBaesken-9f4ec21f-master in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 9f4ec21f from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 16 Feb 2024 and was reviewed by Severin Gehwolf, Thomas Stuefe and Martin Doerr.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev.git backport-MBaesken-9f4ec21f-master:backport-MBaesken-9f4ec21f-master
$ git checkout backport-MBaesken-9f4ec21f-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev.git backport-MBaesken-9f4ec21f-master

⚠️ @MBaesken You are not yet a collaborator in my fork openjdk-bots/jdk11u-dev. An invite will be sent out and you need to accept it before you can proceed.

Please sign in to comment.