Skip to content

Commit a4f870d

Browse files
committed
8357510: [REDO] RunTest variables should always be assigned
Reviewed-by: erikj
1 parent 7bd8375 commit a4f870d

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

make/RunTests.gmk

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -583,6 +583,8 @@ define SetMicroValue
583583
else
584584
ifneq ($3, )
585585
$1_$2 := $3
586+
else
587+
$1_$2 :=
586588
endif
587589
endif
588590
endef
@@ -709,6 +711,8 @@ define SetJtregValue
709711
else
710712
ifneq ($3, )
711713
$1_$2 := $3
714+
else
715+
$1_$2 :=
712716
endif
713717
endif
714718
endif
@@ -841,6 +845,12 @@ define SetupRunJtregTestBody
841845
endif
842846
endif
843847

848+
ifeq ($$(JTREG_RUN_PROBLEM_LISTS), true)
849+
JTREG_PROBLEM_LIST_PREFIX := -match:
850+
else
851+
JTREG_PROBLEM_LIST_PREFIX := -exclude:
852+
endif
853+
844854
ifneq ($$(JTREG_TEST_THREAD_FACTORY), )
845855
$1_JTREG_BASIC_OPTIONS += -testThreadFactoryPath:$$(JTREG_TEST_THREAD_FACTORY_JAR)
846856
$1_JTREG_BASIC_OPTIONS += -testThreadFactory:$$(JTREG_TEST_THREAD_FACTORY)
@@ -869,7 +879,7 @@ define SetupRunJtregTestBody
869879
# version of the JDK.
870880
$1_JTREG_BASIC_OPTIONS += -$$($1_JTREG_TEST_MODE) \
871881
-verbose:$$(JTREG_VERBOSE) -retain:$$(JTREG_RETAIN) \
872-
-concurrency:$$($1_JTREG_JOBS) -timeoutFactor:$$(JTREG_TIMEOUT_FACTOR) \
882+
-concurrency:$$($1_JTREG_JOBS) \
873883
-vmoption:-XX:MaxRAMPercentage=$$($1_JTREG_MAX_RAM_PERCENTAGE) \
874884
-vmoption:-Dtest.boot.jdk="$$(BOOT_JDK)" \
875885
-vmoption:-Djava.io.tmpdir="$$($1_TEST_TMP_DIR)"
@@ -902,12 +912,6 @@ define SetupRunJtregTestBody
902912
$1_JTREG_BASIC_OPTIONS += -nativepath:$$($1_JTREG_NATIVEPATH)
903913
endif
904914

905-
ifeq ($$(JTREG_RUN_PROBLEM_LISTS), true)
906-
JTREG_PROBLEM_LIST_PREFIX := -match:
907-
else
908-
JTREG_PROBLEM_LIST_PREFIX := -exclude:
909-
endif
910-
911915
ifneq ($$($1_JTREG_PROBLEM_LIST), )
912916
$1_JTREG_BASIC_OPTIONS += $$(addprefix $$(JTREG_PROBLEM_LIST_PREFIX), $$($1_JTREG_PROBLEM_LIST))
913917
endif
@@ -994,6 +998,7 @@ define SetupRunJtregTestBody
994998
endif
995999

9961000
JTREG_TIMEOUT_FACTOR ?= $$(JTREG_AUTO_TIMEOUT_FACTOR)
1001+
$1_JTREG_BASIC_OPTIONS += -timeoutFactor:$$(JTREG_TIMEOUT_FACTOR)
9971002

9981003
clean-outputdirs-$1:
9991004
$$(call LogWarn, Clean up dirs for $1)

0 commit comments

Comments
 (0)