Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
8282404: DrawStringWithInfiniteXform.java failed with "RuntimeExcepti…
…on: drawString with InfiniteXform transform takes long time"

Reviewed-by: psadhukhan, jdv
  • Loading branch information
prrace committed Nov 17, 2022
1 parent 66228f7 commit a53be20
Showing 1 changed file with 29 additions and 14 deletions.
43 changes: 29 additions & 14 deletions test/jdk/java/awt/FontClass/DrawStringWithInfiniteXform.java
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -24,13 +24,13 @@
* @test
* @bug 8023213
* @summary Font/Text APIs should not crash/takes long time
* if transform includes INIFINITY
* if transform includes INFINITY
* @run main DrawStringWithInfiniteXform
*/
import java.awt.*;
import java.awt.font.*;
import java.awt.geom.*;
import java.awt.image.*;
import java.awt.Font;
import java.awt.Graphics2D;
import java.awt.geom.AffineTransform;
import java.awt.image.BufferedImage;
import java.util.Timer;
import java.util.TimerTask;

Expand All @@ -41,15 +41,22 @@ public class DrawStringWithInfiniteXform {

class ScheduleTask extends TimerTask {
public void run() {
if (!done) {
throw new
RuntimeException("drawString with InfiniteXform transform takes long time");
System.out.println("Task running at " + System.currentTimeMillis());
System.out.flush();
synchronized (DrawStringWithInfiniteXform.class) {
System.out.println(
"Checking done at " + System.currentTimeMillis());
System.out.flush();
if (!done) {
throw new RuntimeException(
"drawString with InfiniteXform transform takes long time");
}
}
}
}
public DrawStringWithInfiniteXform() {
timer = new Timer();
timer.schedule(new ScheduleTask(), 20000);
timer.schedule(new ScheduleTask(), 30000);
}

public static void main(String [] args) {
Expand All @@ -58,11 +65,15 @@ public static void main(String [] args) {
}

private void start() {
System.out.println("start at " + System.currentTimeMillis());
System.out.flush();
float[] vals = new float[6];
for (int i=0;i<6;i++) vals[i]=Float.POSITIVE_INFINITY;
for (int i=0; i<6; i++) {
vals[i] = Float.POSITIVE_INFINITY;
}
AffineTransform nanTX = new AffineTransform(vals);

BufferedImage bi = new BufferedImage(1,1,BufferedImage.TYPE_INT_RGB);
BufferedImage bi = new BufferedImage(1, 1, BufferedImage.TYPE_INT_RGB);
Graphics2D g2d = bi.createGraphics();

g2d.rotate(Float.POSITIVE_INFINITY);
Expand All @@ -73,8 +84,12 @@ private void start() {
g2d.setFont(xfiniteFont);
g2d.drawString("abc", 20, 20);
}
done = true;
timer.cancel();
System.out.println("Loop done at " + System.currentTimeMillis());
System.out.flush();
synchronized (DrawStringWithInfiniteXform.class) {
done = true;
timer.cancel();
}
System.out.println("Test passed");
}
}

3 comments on commit a53be20

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealMDoerr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on a53be20 Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealMDoerr the backport was successfully created on the branch TheRealMDoerr-backport-a53be204 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit a53be204 from the openjdk/jdk repository.

The commit being backported was authored by Phil Race on 17 Nov 2022 and was reviewed by Prasanta Sadhukhan and Jayathirth D V.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git TheRealMDoerr-backport-a53be204:TheRealMDoerr-backport-a53be204
$ git checkout TheRealMDoerr-backport-a53be204
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git TheRealMDoerr-backport-a53be204

Please sign in to comment.