Skip to content

Commit

Permalink
8297186: G1 triggers unnecessary full GCs when heap utilization is low
Browse files Browse the repository at this point in the history
Reviewed-by: kbarrett, sjohanss
  • Loading branch information
Thomas Schatzl committed Dec 6, 2022
1 parent 4458de9 commit a9e6c62
Show file tree
Hide file tree
Showing 4 changed files with 135 additions and 31 deletions.
73 changes: 45 additions & 28 deletions src/hotspot/share/gc/g1/g1Policy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -188,15 +188,19 @@ uint G1Policy::calculate_desired_eden_length_by_mmu() const {
}

void G1Policy::update_young_length_bounds() {
assert(!Universe::is_fully_initialized() || SafepointSynchronize::is_at_safepoint(), "must be");
bool for_young_only_phase = collector_state()->in_young_only_phase();
// Request at least one eden region to ensure progress.
bool after_gc = true;
update_young_length_bounds(_analytics->predict_pending_cards(for_young_only_phase),
_analytics->predict_rs_length(for_young_only_phase));
_analytics->predict_rs_length(for_young_only_phase),
after_gc);
}

void G1Policy::update_young_length_bounds(size_t pending_cards, size_t rs_length) {
void G1Policy::update_young_length_bounds(size_t pending_cards, size_t rs_length, bool after_gc) {
uint old_young_list_target_length = young_list_target_length();

uint new_young_list_desired_length = calculate_young_desired_length(pending_cards, rs_length);
uint new_young_list_desired_length = calculate_young_desired_length(pending_cards, rs_length, after_gc);
uint new_young_list_target_length = calculate_young_target_length(new_young_list_desired_length);
uint new_young_list_max_length = calculate_young_max_length(new_young_list_target_length);

Expand Down Expand Up @@ -224,28 +228,24 @@ void G1Policy::update_young_length_bounds(size_t pending_cards, size_t rs_length
//
// - sizer min/max bounds on young gen
// - pause time goal for whole young gen evacuation
// - MMU goal influencing eden to make GCs spaced apart.
// - a minimum one eden region length.
// - MMU goal influencing eden to make GCs spaced apart
// - if after a GC, request at least one eden region to avoid immediate full gcs
//
// We may enter with already allocated eden and survivor regions, that may be
// higher than the maximum, or the above goals may result in a desired value
// smaller than are already allocated.
// The main reason is revising young length, with or without the GCLocker being
// active.
// We may enter with already allocated eden and survivor regions because there
// are survivor regions (after gc). Young gen revising can call this method at any
// time too.
//
uint G1Policy::calculate_young_desired_length(size_t pending_cards, size_t rs_length) const {
// For this method it does not matter if the above goals may result in a desired
// value smaller than what is already allocated or what can actually be allocated.
// This return value is only an expectation.
//
uint G1Policy::calculate_young_desired_length(size_t pending_cards, size_t rs_length, bool after_gc) const {
uint min_young_length_by_sizer = _young_gen_sizer.min_desired_young_length();
uint max_young_length_by_sizer = _young_gen_sizer.max_desired_young_length();

assert(min_young_length_by_sizer >= 1, "invariant");
assert(max_young_length_by_sizer >= min_young_length_by_sizer, "invariant");

// Absolute minimum eden length.
// Enforcing a minimum eden length helps at startup when the predictors are not
// yet trained on the application to avoid unnecessary (but very short) full gcs
// on very small (initial) heaps.
uint const MinDesiredEdenLength = 1;

// Calculate the absolute and desired min bounds first.

// This is how many survivor regions we already have.
Expand All @@ -261,6 +261,10 @@ uint G1Policy::calculate_young_desired_length(size_t pending_cards, size_t rs_le
// so adjust the result accordingly.
uint absolute_max_young_length = MAX2(max_young_length_by_sizer, absolute_min_young_length);

// The absolute minimum young gen length (as provided by the young gen sizer) ensures
// that we desire at least one young gen region.
assert(absolute_min_young_length > 0, "must be");

uint desired_eden_length_by_mmu = 0;
uint desired_eden_length_by_pause = 0;

Expand All @@ -277,10 +281,8 @@ uint G1Policy::calculate_young_desired_length(size_t pending_cards, size_t rs_le

// Incorporate MMU concerns; assume that it overrides the pause time
// goal, as the default value has been chosen to effectively disable it.
// Also request at least one eden region, see above for reasons.
uint desired_eden_length = MAX3(desired_eden_length_by_pause,
desired_eden_length_by_mmu,
MinDesiredEdenLength);
uint desired_eden_length = MAX2(desired_eden_length_by_pause,
desired_eden_length_by_mmu);

desired_young_length = desired_eden_length + survivor_length;
} else {
Expand All @@ -291,19 +293,31 @@ uint G1Policy::calculate_young_desired_length(size_t pending_cards, size_t rs_le
// Clamp to absolute min/max after we determined desired lengths.
desired_young_length = clamp(desired_young_length, absolute_min_young_length, absolute_max_young_length);

log_trace(gc, ergo, heap)("Young desired length %u "
// After a garbage collection, make room for at least one eden region (i.e. in addition to
// already allocated survivor regions).
// This may make desired regions go over absolute maximum length by the heap sizer, however
// the immediate full gcs after that young gc (particularly on small heaps) are worse.
if (after_gc && (allocated_young_length >= desired_young_length)) {
log_trace(gc, ergo, heap)("Young desired length: Desired young region length less than already "
"allocated region length, but requesting one eden region minimum. "
"Expanding desired young length from %u to %u.",
desired_young_length,
allocated_young_length + 1);
desired_young_length = allocated_young_length + 1;
}

log_trace(gc, ergo, heap)("Young desired length %u (after gc: %s) "
"survivor length %u "
"allocated young length %u "
"absolute min young length %u "
"absolute max young length %u "
"desired eden length by mmu %u "
"desired eden length by pause %u "
"desired eden length by default %u",
desired_young_length, survivor_length,
"desired eden length by pause %u ",
desired_young_length, BOOL_TO_STR(after_gc),
survivor_length,
allocated_young_length, absolute_min_young_length,
absolute_max_young_length, desired_eden_length_by_mmu,
desired_eden_length_by_pause,
MinDesiredEdenLength);
desired_eden_length_by_pause);

assert(desired_young_length >= allocated_young_length, "must be");
return desired_young_length;
Expand Down Expand Up @@ -534,7 +548,10 @@ void G1Policy::revise_young_list_target_length(size_t rs_length) {
size_t thread_buffer_cards = _analytics->predict_dirtied_cards_in_thread_buffers();
G1DirtyCardQueueSet& dcqs = G1BarrierSet::dirty_card_queue_set();
size_t pending_cards = dcqs.num_cards() + thread_buffer_cards;
update_young_length_bounds(pending_cards, rs_length);
// We are only revising young gen length to meet pause time goal, so do not request
// at least one eden region for progress. At this point we actually want to run into
// a GC soon if young gen is already (too) large.
update_young_length_bounds(pending_cards, rs_length, false /* need_one_eden_region */);
}

void G1Policy::record_full_collection_start() {
Expand Down
7 changes: 4 additions & 3 deletions src/hotspot/share/gc/g1/g1Policy.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,10 @@ class G1Policy: public CHeapObj<mtGC> {

// Updates the internal young gen maximum and target and desired lengths.
// If no parameters are passed, predict pending cards and the RS length using
// the prediction model.
// the prediction model. If after_gc is set, make sure that there is one eden region
// available (if there is enough space) to guarantee some progress.
void update_young_length_bounds();
void update_young_length_bounds(size_t pending_cards, size_t rs_length);
void update_young_length_bounds(size_t pending_cards, size_t rs_length, bool after_gc);

// Calculate and return the minimum desired eden length based on the MMU target.
uint calculate_desired_eden_length_by_mmu() const;
Expand Down Expand Up @@ -240,7 +241,7 @@ class G1Policy: public CHeapObj<mtGC> {

// Calculate desired young length based on current situation without taking actually
// available free regions into account.
uint calculate_young_desired_length(size_t pending_cards, size_t rs_length) const;
uint calculate_young_desired_length(size_t pending_cards, size_t rs_length, bool after_gc) const;
// Limit the given desired young length to available free regions.
uint calculate_young_target_length(uint desired_young_length) const;
// The GCLocker might cause us to need more regions than the target. Calculate
Expand Down
85 changes: 85 additions & 0 deletions test/hotspot/jtreg/gc/g1/TestOneEdenRegionAfterGC.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

package gc.g1;

/*
* @test
* @bug 8297186
* @requires vm.gc.G1
* @library /test/lib
* @run driver gc.g1.TestOneEdenRegionAfterGC
* @summary Test that on a very small heap g1 with very little data (smaller than region size)
* will use at least one eden region after gc to avoid full gcs.
*/

import jdk.test.lib.process.OutputAnalyzer;
import jdk.test.lib.process.ProcessTools;

public class TestOneEdenRegionAfterGC {
private static long YoungGenSize = 32 * 1024 * 1024;

private static OutputAnalyzer run() throws Exception {
ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
"-Xbootclasspath/a:.",
"-Xmn" + YoungGenSize,
"-Xmx512M",
"-Xms512M",
"-XX:G1HeapRegionSize=32M",
"-XX:+UseG1GC",
"-Xlog:gc,gc+ergo*=trace",
TestOneEdenRegionAfterGC.Allocate.class.getName(),
"" + YoungGenSize);
return new OutputAnalyzer(pb.start());
}

public static void main(String args[]) throws Exception {
OutputAnalyzer out = run();

out.shouldMatch(".*Pause Young \\(Normal\\).*");
out.shouldNotMatch(".*Pause Full.*");
}

public static class Allocate {
public static Object dummy;

public static void main(String [] args) throws Exception {
if (args.length != 1) {
throw new IllegalArgumentException("Usage: <YoungGenSize>");
}

long youngGenSize = Long.parseLong(args[0]);
triggerYoungGCs(youngGenSize);
}

public static void triggerYoungGCs(long youngGenSize) {
long approxAllocSize = 32 * 1024;
long numAllocations = 2 * youngGenSize / approxAllocSize;

for (long i = 0; i < numAllocations; i++) {
dummy = new byte[(int)approxAllocSize];
}
}
}
}

1 change: 1 addition & 0 deletions test/hotspot/jtreg/runtime/cds/appcds/LotsOfClasses.java
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public static void main(String[] args) throws Exception {
opts.addSuffix("ALL-SYSTEM");
opts.addSuffix("-Xlog:hashtables");
opts.addSuffix("-Xmx500m");
opts.addSuffix("-XX:MetaspaceSize=500M"); // avoid heap fragmentation by avoiding metaspace-limit induced GCs
opts.addSuffix("-Xlog:gc+region+cds");
opts.addSuffix("-Xlog:cds=debug"); // test detailed metadata info printing

Expand Down

1 comment on commit a9e6c62

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.