Skip to content

Commit

Permalink
8321207: javac is not accepting correct code
Browse files Browse the repository at this point in the history
Reviewed-by: jlahoda
  • Loading branch information
Vicente Romero committed Dec 6, 2023
1 parent 86b27b7 commit aaaae3e
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,12 @@ protected void forEachInitializer(JCClassDecl classDef, boolean isStatic, Consum
try {
for (List<JCTree> defs = classDef.defs; defs.nonEmpty(); defs = defs.tail) {
JCTree def = defs.head;
if (!def.hasTag(METHODDEF) && ((TreeInfo.flags(def) & STATIC) != 0) == isStatic)
/* we need to check for flags in the symbol too as there could be cases for which implicit flags are
* represented in the symbol but not in the tree modifiers as they were not originally in the source
* code
*/
boolean isDefStatic = ((TreeInfo.flags(def) | (TreeInfo.symbolFor(def) == null ? 0 : TreeInfo.symbolFor(def).flags_field)) & STATIC) != 0;
if (!def.hasTag(METHODDEF) && (isDefStatic == isStatic))
handler.accept(def);
}
} finally {
Expand Down
39 changes: 39 additions & 0 deletions test/langtools/tools/javac/lambda/LambdaCapture08.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
/*
* Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8321207
* @summary javac is not accepting correct code
* @compile LambdaCapture08.java
*/

import java.util.function.*;

interface LambdaCapture08 {
Object O = new Object() {
IntSupplier x(int m) {
return () -> m;
}
};
}

1 comment on commit aaaae3e

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.