Skip to content

Commit ab23500

Browse files
committed
8354636: [PPC64] Clean up comments regarding frame manager
Reviewed-by: amitkumar, rrich
1 parent f141674 commit ab23500

File tree

3 files changed

+11
-13
lines changed

3 files changed

+11
-13
lines changed

src/hotspot/cpu/ppc/register_ppc.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ constexpr FloatRegister F11_ARG11 = F11; // volatile
523523
constexpr FloatRegister F12_ARG12 = F12; // volatile
524524
constexpr FloatRegister F13_ARG13 = F13; // volatile
525525

526-
// Register declarations to be used in frame manager assembly code.
526+
// Register declarations to be used in template interpreter assembly code.
527527
// Use only non-volatile registers in order to keep values across C-calls.
528528
constexpr Register R14_bcp = R14;
529529
constexpr Register R15_esp = R15; // slot below top of expression stack for ld/st with update
@@ -533,7 +533,7 @@ constexpr Register R17_tos = R17; // The interpreter's top of (expres
533533
constexpr Register R18_locals = R18; // address of first param slot (receiver).
534534
constexpr Register R19_method = R19; // address of current method
535535

536-
// Temporary registers to be used within frame manager. We can use
536+
// Temporary registers to be used within template interpreter. We can use
537537
// the non-volatiles because the call stub has saved them.
538538
// Use only non-volatile registers in order to keep values across C-calls.
539539
constexpr Register R21_tmp1 = R21;

src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2935,7 +2935,7 @@ static void push_skeleton_frames(MacroAssembler* masm, bool deopt,
29352935
__ cmpdi(CR0, number_of_frames_reg, 0);
29362936
__ bne(CR0, loop);
29372937

2938-
// Get the return address pointing into the frame manager.
2938+
// Get the return address pointing into the template interpreter.
29392939
__ ld(R0, 0, pcs_reg);
29402940
// Store it in the top interpreter frame.
29412941
__ std(R0, _abi0(lr), R1_SP);

src/hotspot/cpu/ppc/stubGenerator_ppc.cpp

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ class StubGenerator: public StubCodeGenerator {
8686
// R10 - thread : Thread*
8787
//
8888
address generate_call_stub(address& return_address) {
89-
// Setup a new c frame, copy java arguments, call frame manager or
89+
// Setup a new c frame, copy java arguments, call template interpreter or
9090
// native_entry, and process result.
9191

9292
StubGenStubId stub_id = StubGenStubId::call_stub_id;
@@ -215,11 +215,10 @@ class StubGenerator: public StubCodeGenerator {
215215
}
216216

217217
{
218-
BLOCK_COMMENT("Call frame manager or native entry.");
219-
// Call frame manager or native entry.
218+
BLOCK_COMMENT("Call template interpreter or native entry.");
220219
assert_different_registers(r_arg_entry, r_top_of_arguments_addr, r_arg_method, r_arg_thread);
221220

222-
// Register state on entry to frame manager / native entry:
221+
// Register state on entry to template interpreter / native entry:
223222
//
224223
// tos - intptr_t* sender tos (prepushed) Lesp = (SP) + copied_arguments_offset - 8
225224
// R19_method - Method
@@ -242,7 +241,7 @@ class StubGenerator: public StubCodeGenerator {
242241

243242
// Set R15_prev_state to 0 for simplifying checks in callee.
244243
__ load_const_optimized(R25_templateTableBase, (address)Interpreter::dispatch_table((TosState)0), R0);
245-
// Stack on entry to frame manager / native entry:
244+
// Stack on entry to template interpreter / native entry:
246245
//
247246
// F0 [TOP_IJAVA_FRAME_ABI]
248247
// alignment (optional)
@@ -262,19 +261,18 @@ class StubGenerator: public StubCodeGenerator {
262261
__ mr(R21_sender_SP, R1_SP);
263262

264263
// Do a light-weight C-call here, r_arg_entry holds the address
265-
// of the interpreter entry point (frame manager or native entry)
264+
// of the interpreter entry point (template interpreter or native entry)
266265
// and save runtime-value of LR in return_address.
267266
assert(r_arg_entry != tos && r_arg_entry != R19_method && r_arg_entry != R16_thread,
268267
"trashed r_arg_entry");
269268
return_address = __ call_stub(r_arg_entry);
270269
}
271270

272271
{
273-
BLOCK_COMMENT("Returned from frame manager or native entry.");
274-
// Returned from frame manager or native entry.
272+
BLOCK_COMMENT("Returned from template interpreter or native entry.");
275273
// Now pop frame, process result, and return to caller.
276274

277-
// Stack on exit from frame manager / native entry:
275+
// Stack on exit from template interpreter / native entry:
278276
//
279277
// F0 [ABI]
280278
// ...
@@ -295,7 +293,7 @@ class StubGenerator: public StubCodeGenerator {
295293
Register r_cr = R12_scratch2;
296294

297295
// Reload some volatile registers which we've spilled before the call
298-
// to frame manager / native entry.
296+
// to template interpreter / native entry.
299297
// Access all locals via frame pointer, because we know nothing about
300298
// the topmost frame's size.
301299
__ ld(r_entryframe_fp, _abi0(callers_sp), R1_SP); // restore after call

0 commit comments

Comments
 (0)