Skip to content

Commit

Permalink
8313323: javac -g on a java file which uses unnamed variable leads to…
Browse files Browse the repository at this point in the history
… ClassFormatError when launching that class

Reviewed-by: vromero
  • Loading branch information
lahodaj committed Sep 4, 2023
1 parent 2dc930d commit adfc1d6
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2189,6 +2189,8 @@ void putVar(LocalVar var) {
((var.sym.owner.flags() & Flags.LAMBDA_METHOD) == 0 ||
(var.sym.flags() & Flags.PARAMETER) == 0);
if (ignoredSyntheticVar) return;
//don't include unnamed variables:
if (var.sym.name == var.sym.name.table.names.empty) return ;
if (varBuffer == null)
varBuffer = new LocalVar[20];
else
Expand Down
49 changes: 49 additions & 0 deletions test/langtools/tools/javac/unnamed/UnnamedLocalVariableTable.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
/*
* Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/**
* @test
* @bug 8313323
* @summary Verify javac does not produce incorrect LocalVariableTable
* @enablePreview
* @compile -g UnnamedLocalVariableTable.java
* @run main UnnamedLocalVariableTable
*/
public class UnnamedLocalVariableTable {
public static void main(String... args) {
try {
int _ = 0;
if (args[0] instanceof String _) {
System.err.println("1");
}
I i = _ -> {};
java.util.List<String> _ = null;
} catch (Exception _) {
System.err.println("2");
}
}

interface I {
public void test(String s);
}
}

1 comment on commit adfc1d6

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.