8257604: JNI_ArgumentPusherVaArg leaks valist

Reviewed-by: dcubed, coleenp
openjdk · Dec 3, 2020 · ae1eb28 · ae1eb28 · openjdk-notifier · Dec 3, 2020
1 parent 4169d96
commit ae1eb28
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/hotspot/share/prims/jni.cpp b/src/hotspot/share/prims/jni.cpp
@@ -870,7 +870,6 @@ class JNI_ArgumentPusher : public SignatureIterator {
 
 
 class JNI_ArgumentPusherVaArg : public JNI_ArgumentPusher {
- protected:
   va_list _ap;
 
   void set_ap(va_list rap) {
@@ -906,6 +905,10 @@ class JNI_ArgumentPusherVaArg : public JNI_ArgumentPusher {
     set_ap(rap);
   }
 
+  ~JNI_ArgumentPusherVaArg() {
+    va_end(_ap);
+  }
+
   virtual void push_arguments_on(JavaCallArguments* arguments) {
     _arguments = arguments;
     do_parameters_on(this);